Closed
Bug 1272732
Opened 9 years ago
Closed 9 years ago
Specifying --disable-android-apz breaks Fennec build.
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Firefox for Android Graveyard
Toolbar
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: rbarker, Assigned: rbarker)
References
Details
Attachments
(1 file, 1 obsolete file)
856 bytes,
patch
|
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When specifying --disable-android-apz, the build will fail trying to build file FlingOverScrollerAnimation.cpp which should only be include in APZ builds.
Assignee | ||
Updated•9 years ago
|
Summary: Fennec JPZ build broken in 49 nightly → Specifying --disable-android-apz breaks Fennec build.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8752286 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rbarker
Comment 2•9 years ago
|
||
Comment on attachment 8752286 [details] [diff] [review]
0001-Bug-1272732-Specifying-disable-android-apz-breaks-Fennec-build.-r-16051311-989265f.patch
Review of attachment 8752286 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/moz.build
@@ +253,5 @@
> 'ipc/GonkNativeHandleUtils.cpp',
> 'ipc/ShadowLayerUtilsGralloc.cpp',
> ]
>
> +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android' and CONFIG['MOZ_ANDROID_APZ']:
Can we do just the MOZ_ANDROID_APZ check? That implies the toolkit thing already, and would make it consistent with the ifdefs in the code.
Attachment #8752286 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Simplify patch. Carry forward r+ from :kats
Attachment #8752286 -
Attachment is obsolete: true
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 6•9 years ago
|
||
Randall, please make sure you mark dependencies properly. This needs uplifting to 48.
Blocks: 1229462
status-firefox48:
--- → affected
Comment 7•9 years ago
|
||
Comment on attachment 8752299 [details] [diff] [review]
0001-Bug-1272732-Specifying-disable-android-apz-breaks-Fennec-build.-r-16051311-4eceae6.patch
Approval Request Comment
[Feature/regressing bug #]: bug 1229462
[User impact if declined]: harder to turn off APZ on Fennec if we need to (not likely that we will, but just in case)
[Describe test coverage new/current, TreeHerder]: tested locally
[Risks and why]: low risk, just a build config change that doesn't affect the default configuration
[String/UUID change made/needed]: none
Attachment #8752299 -
Flags: approval-mozilla-beta?
Comment 8•9 years ago
|
||
Comment on attachment 8752299 [details] [diff] [review]
0001-Bug-1272732-Specifying-disable-android-apz-breaks-Fennec-build.-r-16051311-4eceae6.patch
Let's do it in case we disable it!
should be in 48 beta 5
Attachment #8752299 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•9 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•