PaintedLayerDataTree::FindPaintedLayerFor has an argument aForceOwnLayer that's always false

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This argument is no longer needed, the only caller passes "false" always. We should remove the argument and anything else that becomes unnecessary because of it.

https://dxr.mozilla.org/mozilla-central/rev/1f1a8b96d5167153d1f750439ba6a1063155a4bc/layout/base/FrameLayerBuilder.cpp#2822
(Assignee)

Comment 1

3 years ago
(Apparently I should have put my email address into the "Mentors" field, not into the whiteboard.)
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Whiteboard: [good first bug][mentor=mstange][lang=c++]
(Assignee)

Comment 2

3 years ago
Created attachment 8759339 [details]
Bug 1272801 - Remove unused aForceOwnLayer argument.

Review commit: https://reviewboard.mozilla.org/r/57330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57330/
Attachment #8759339 - Flags: review?(matt.woodrow)
Comment on attachment 8759339 [details]
Bug 1272801 - Remove unused aForceOwnLayer argument.

https://reviewboard.mozilla.org/r/57330/#review54148
Attachment #8759339 - Flags: review?(matt.woodrow) → review+

Comment 4

3 years ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b28d1c65f0a1
Remove unused aForceOwnLayer argument. r=mattwoodrow

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b28d1c65f0a1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.