Closed
Bug 1272845
Opened 8 years ago
Closed 5 years ago
Intermittent e10s browser_bug1025195_switchToTabHavingURI_aOpenParams.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW
Categories
(Firefox :: General, defect, P5)
Firefox
General
Tracking
()
People
(Reporter: philor, Assigned: kevchan85)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.45 KB,
patch
|
mak
:
review-
|
Details | Diff | Splinter Review |
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 8•8 years ago
|
||
Jared, this is showing up as one of the more regular dead CPOW oranges being hit in automation. Can you please take a look? TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_bug1025195_switchToTabHavingURI_aOpenParams.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_bug1025195_switchToTabHavingURI_aOpenParams.js:18 - Error: operation not possible on dead CPOW Stack trace: test_ignoreFragment/hashChangePromise<@chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_bug1025195_switchToTabHavingURI_aOpenParams.js:18:5 Promise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:388:5 test_ignoreFragment@chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_bug1025195_switchToTabHavingURI_aOpenParams.js:17:27 Tester_execTest@chrome://mochikit/content/browser-test.js:784:9 Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:704:7 SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:743:59 Tester_execTest@chrome://mochikit/content/browser-test.js:784:9 Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:704:7 SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:743:59 https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/urlbar/browser_bug1025195_switchToTabHavingURI_aOpenParams.js#18 > tabRefAboutHome.linkedBrowser.contentWindow.addEventListener("hashchange", resolve, false);
status-firefox49:
--- → wontfix
status-firefox50:
--- → affected
status-firefox51:
--- → affected
Flags: needinfo?(jaws)
Hello I removed the contentWindow... Is this right?
Attachment #8791026 -
Flags: review?(mak77)
Comment 10•8 years ago
|
||
Comment on attachment 8791026 [details] [diff] [review] bug1272845_removed_contentWindow_to_prevent_deadCPOW.diff Review of attachment 8791026 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for long delay. I think you should rather use ContentTask.spawn and add a listener there, you can get a promise out of that, that should work exactly the same as the current one. For example: http://searchfox.org/mozilla-central/rev/dbbbafc979a8362a1c8e3e99dbea188fc832b1c5/browser/components/sessionstore/test/browser_async_flushes.js#19
Attachment #8791026 -
Flags: review?(mak77) → review-
Comment 11•8 years ago
|
||
basically, the current code is using contentWindow that is a CPOW, it is actually speaking with the content process, that is different from the one the test runs in. So it has to send and wait for a synchronous message to get the content window. ContentTask is an util to do that in a better way, it injects your script into content, and gives you a promise that is resolved when the content Task is complete. Everything is properly handled through content scripts and async messaging between the processes. This test should probably also move from gBrowser.addTab to yield BrowserTestUtils.openNewForegroundTab, that also returns a promise when the work is done, and from switchTab to yield BrowserTestUtils.switchTab. You can see all the available utils here: http://searchfox.org/mozilla-central/source/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm
Updated•8 years ago
|
Assignee: nobody → kevchan85
Flags: needinfo?(jaws)
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 12•5 years ago
|
||
No failures seen recently -> WFM
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•