Closed Bug 1272861 Opened 4 years ago Closed 4 years ago

Fix -Wshadow warnings in chrome directory

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- wontfix
firefox49 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

chrome/nsChromeRegistryContent.cpp:114:14 [-Wshadow] declaration shadows a local variable

There is no need to redeclare a second nsresult rv. The first rv value does not need to be preserved.

I plan to enable clang and gcc's -Wshadow warnings in bug 1272513. This is the last -Wshadow warning in the chrome directory.
Attachment #8752445 - Flags: review?(gijskruitbosch+bugs)
Attachment #8752445 - Flags: review?(gijskruitbosch+bugs) → review+
Thanks! This was the last (well, only :) -Wshadow warning in the chrome/ directory.
https://hg.mozilla.org/mozilla-central/rev/d5a526f65118
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.