Created attachment 8752445 [details] [diff] [review] Wshadow_chrome.patch chrome/nsChromeRegistryContent.cpp:114:14 [-Wshadow] declaration shadows a local variable There is no need to redeclare a second nsresult rv. The first rv value does not need to be preserved. I plan to enable clang and gcc's -Wshadow warnings in bug 1272513. This is the last -Wshadow warning in the chrome directory.
Attachment #8752445 - Flags: review?(gijskruitbosch+bugs)
Attachment #8752445 - Flags: review?(gijskruitbosch+bugs) → review+
Thanks! This was the last (well, only :) -Wshadow warning in the chrome/ directory.
status-firefox48: --- → wontfix
status-firefox49: --- → fixed
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.