Fix -Wshadow warnings in chrome directory

RESOLVED FIXED in Firefox 49

Status

()

Firefox
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox48 wontfix, firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8752445 [details] [diff] [review]
Wshadow_chrome.patch

chrome/nsChromeRegistryContent.cpp:114:14 [-Wshadow] declaration shadows a local variable

There is no need to redeclare a second nsresult rv. The first rv value does not need to be preserved.

I plan to enable clang and gcc's -Wshadow warnings in bug 1272513. This is the last -Wshadow warning in the chrome directory.
Attachment #8752445 - Flags: review?(gijskruitbosch+bugs)

Updated

2 years ago
Attachment #8752445 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 2

2 years ago
Thanks! This was the last (well, only :) -Wshadow warning in the chrome/ directory.
status-firefox48: --- → wontfix
status-firefox49: --- → fixed

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d5a526f65118
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.