1272911 - Signature change (nsEventQueue::GetEvent) has confused bugs

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Jonathan Howard]

"nsEventQueue::GetEvent" has been added to some signatures in aurora 48 and nightly 49. (Around merge time I expect but I not found where to place blame.) Seems to have gone unnoticed for past two weeks.

Best highlighted with;
https://crash-stats.mozilla.com/search/?product=Firefox&signature=%3Dshutdownhang%20%7C%20WaitForSingleObjectEx%20%7C%20PR_WaitCondVar%20%7C%20mozilla%3A%3ACondVar%3A%3AWait%20%7C%20nsEventQueue%3A%3AGetEvent&_facets=proto_signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-proto_signature

Top sig;
https://crash-stats.mozilla.com/search/?product=Firefox&signature=%3Dshutdownhang%20%7C%20WaitForSingleObjectEx%20%7C%20WaitForSingleObject%20%7C%20PR_WaitCondVar%20%7C%20mozilla%3A%3ACondVar%3A%3AWait%20%7C%20nsEventQueue%3A%3AGetEvent&_facets=proto_signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-proto_signature

Not sure which are irrelevant;
https://crash-stats.mozilla.com/search/?product=Firefox&signature=~nsEventQueue%3A%3AGetEvent&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

(Leaving clarifying what fix is to next person.)

Comment 1

[Jonathan Howard]

Bug 1186060 likely to candidate to blame. (From looking at bug 1268559 comment 38)

Comment 2

[Jonathan Howard]

No next person came. VS2015 was backed out when I posted and not been very active to see earlier.
Just nsEventQueue::GetEvent is no longer inlined.

I have sent pull request to github that I think fixes this.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e5ee1c24dc9558298a3ab43b687a64f163388371
Bug 1272911 - Add nsEventQueue::GetEvent to prefix list (#3435)

* Bug 1272911 - Add nsEventQueue::GetEvent to prefix list

* Bug 1296966 - Add nsThread::Shutdown to prefix list