Closed Bug 1272966 Opened 4 years ago Closed 4 years ago

Disable c-c apps on MacOS <10.9

Categories

(Thunderbird :: Build Config, defect)

49 Branch
Unspecified
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

Attachment #8752580 - Flags: review?(rkent)
Attachment #8752580 - Flags: review?(philip.chee)
Attachment #8752580 - Flags: review?(florian)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
We need to turn off all tests on build/test machines running 10.6-10.8 before this lands. I don't know about Thunderbird, but I know SeaMonkey have a problem here - afaik all SM machines are on 10.6 or 10.7. Callek/ewong should know more.

For m-c, this changeset was landed at the same time: https://hg.mozilla.org/mozilla-central/rev/1665c708ebab. I don't know for sure if that's shared with c-c, but I suspect that.
Flags: needinfo?(ewong)
(In reply to Stefan [:stefanh] from comment #2)
> We need to turn off all tests on build/test machines running 10.6-10.8
> before this lands. I don't know about Thunderbird, but I know SeaMonkey have
> a problem here - afaik all SM machines are on 10.6 or 10.7. Callek/ewong
> should know more.
> 
> For m-c, this changeset was landed at the same time:
> https://hg.mozilla.org/mozilla-central/rev/1665c708ebab. I don't know for
> sure if that's shared with c-c, but I suspect that.

We're running on 10.7, so yes, we're gonna be hit with this bug.
I'm wondering if we can force our minis to use 10.9?

:Callek, what say you?
Flags: needinfo?(ewong) → needinfo?(bugspam.Callek)
Comment on attachment 8752580 [details] [diff] [review]
Disable c-c apps on MacOS <10.9

Review of attachment 8752580 [details] [diff] [review]:
-----------------------------------------------------------------

I'm afraid we don't have much of a choice here, but it'll be a pain, our current mac builds are done on 10.8 :-(.
Attachment #8752580 - Flags: review?(florian) → review+
Note that this only affect running the application. You should still be able to build with the 10.7 SDK (which I beleive m-c still is doing).
Attachment #8752580 - Flags: review?(philip.chee) → review?(stefanh)
Comment on attachment 8752580 [details] [diff] [review]
Disable c-c apps on MacOS <10.9

Review of attachment 8752580 [details] [diff] [review]:
-----------------------------------------------------------------

I know practically nothing about this area of packaging, but I suppose I can rely on you and the parent patch. So rs=me I suppose.
Attachment #8752580 - Flags: review?(rkent) → review+
Comment on attachment 8752580 [details] [diff] [review]
Disable c-c apps on MacOS <10.9

r=me, but please don't land this until you get OK from ewong or Callek.
Attachment #8752580 - Flags: review?(stefanh) → review+
Tests on 10.6 are now disabled for TB 49+ (Bug 1278102).
ewong: do you think we can land this? I'm unsure if you can actually run anything on 10.7 now... For example, the landing of bug 1272764 ought to have caused problems running a mozilla app on 10.6-10.8.
Flags: needinfo?(ewong)
(In reply to Stefan [:stefanh] from comment #9)
> ewong: do you think we can land this? I'm unsure if you can actually run
> anything on 10.7 now... For example, the landing of bug 1272764 ought to
> have caused problems running a mozilla app on 10.6-10.8.

Sure.  I'll land it.(In reply to Stefan [:stefanh] from comment #9)
> ewong: do you think we can land this? I'm unsure if you can actually run
> anything on 10.7 now... For example, the landing of bug 1272764 ought to
> have caused problems running a mozilla app on 10.6-10.8.

If there are no objections, I'll land this.  tbh, quite clueless in what
this means aside for turning our OSX64 from orange to red?
Flags: needinfo?(ewong)
(In reply to Edmund Wong (:ewong) from comment #10) 
> If there are no objections, I'll land this.  tbh, quite clueless in what
> this means aside for turning our OSX64 from orange to red?

Orange to red, yes - I think that's all.
I took the liberty to pushed this with an a=ewong as https://hg.mozilla.org/comm-central/rev/9452a67bfbe3.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
OS: Unspecified → Mac OS X
Flags: needinfo?(bugspam.Callek)
You need to log in before you can comment on or make changes to this bug.