1272988 - Check for null when detecting outgoing invitations

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[[:MakeMyDay]]

If a calendar refresh occurs while displaying an invitation email, the following error messages show up in the error console:

Zeitstempel: 08.05.2016 16:41:39
Fehler: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]'[JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]' when calling method: [calIOperationListener::onOperationComplete]
Quelldatei: file:///C:/Users/xxxxx/AppData/Roaming/Thunderbird/Profiles/7yrfxmv9.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js
Zeile: 509

Zeitstempel: 08.05.2016 16:41:39
Fehler: [Exception... "[JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]'[JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]' when calling method: [calIOperationListener::onOperationComplete]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Users/xxxxxxxxxxxx/AppData/Roaming/Thunderbird/Profiles/7yrfxmv9.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js :: calCompositeGetListenerHelper.prototype.onOperationComplete :: line 509"  data: yes]
Quelldatei: resource://calendar/modules/calProviderUtils.jsm
Zeile: 641

The patch for bug 1241600 lacked a null check here.

In that case gMessageDisplay.displayedMessage is null, which triggers the error, though its not quite clear why it is.

Comment 1

[[:MakeMyDay]]

Attachment: AddNullCheck-V1.diff

This patch simply adds a null check.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8752603 [details] [diff] [review]
AddNullCheck-V1.diff

Review of attachment 8752603 [details] [diff] [review]:
-----------------------------------------------------------------

Would be interesting to know why this is null, but I am ok with the null check here.

Comment 3

[[:MakeMyDay]]

https://hg.mozilla.org/comm-central/rev/0a6bf6158318c122140de23b6bdc322eefaf58fb

Comment 4

[[:MakeMyDay]]

https://hg.mozilla.org/releases/comm-aurora/rev/5b0a987ce1965179956cc5262f3272ea1adc0861
https://hg.mozilla.org/releases/comm-beta/rev/0dbd8ee150fb62ac5e695db93c8293976a93d382
https://hg.mozilla.org/releases/comm-esr45/rev/629001d1a1a0da5ef05692bd2cf1170eae9db476