Check for null when detecting outgoing invitations

RESOLVED FIXED in 4.7.2

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Tracking

({regression})

Lightning 4.7
4.7.2
Dependency tree / graph

Details

Attachments

(1 attachment)

If a calendar refresh occurs while displaying an invitation email, the following error messages show up in the error console:

Zeitstempel: 08.05.2016 16:41:39
Fehler: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]'[JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]' when calling method: [calIOperationListener::onOperationComplete]
Quelldatei: file:///C:/Users/xxxxx/AppData/Roaming/Thunderbird/Profiles/7yrfxmv9.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js
Zeile: 509

Zeitstempel: 08.05.2016 16:41:39
Fehler: [Exception... "[JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]'[JavaScript Error: "aMsgHdr is null" {file: "chrome://lightning/content/imip-bar.js" line: 210}]' when calling method: [calIOperationListener::onOperationComplete]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Users/xxxxxxxxxxxx/AppData/Roaming/Thunderbird/Profiles/7yrfxmv9.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js :: calCompositeGetListenerHelper.prototype.onOperationComplete :: line 509"  data: yes]
Quelldatei: resource://calendar/modules/calProviderUtils.jsm
Zeile: 641

The patch for bug 1241600 lacked a null check here.

In that case gMessageDisplay.displayedMessage is null, which triggers the error, though its not quite clear why it is.
Blocks: 1241600
This patch simply adds a null check.
Attachment #8752603 - Flags: review?(philipp)
Attachment #8752603 - Flags: approval-calendar-esr?(philipp)
Attachment #8752603 - Flags: approval-calendar-beta?(philipp)
Attachment #8752603 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8752603 [details] [diff] [review]
AddNullCheck-V1.diff

Review of attachment 8752603 [details] [diff] [review]:
-----------------------------------------------------------------

Would be interesting to know why this is null, but I am ok with the null check here.
Attachment #8752603 - Flags: review?(philipp)
Attachment #8752603 - Flags: review+
Attachment #8752603 - Flags: approval-calendar-esr?(philipp)
Attachment #8752603 - Flags: approval-calendar-esr+
Attachment #8752603 - Flags: approval-calendar-beta?(philipp)
Attachment #8752603 - Flags: approval-calendar-beta+
Attachment #8752603 - Flags: approval-calendar-aurora?(philipp)
Attachment #8752603 - Flags: approval-calendar-aurora+
https://hg.mozilla.org/comm-central/rev/0a6bf6158318c122140de23b6bdc322eefaf58fb
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.1
You need to log in before you can comment on or make changes to this bug.