1272999 - Multiline code pasted in console is still partially clipped

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Oriol Brufau [:Oriol]]

Attachment: Screenshot

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160514030209

Steps to reproduce:

Enter multiline code in the console, either with Shift+Enter or pasting.


Actual results:

The text is partially clipped.


Expected results:

The case is bug 1242851. Bug 1271095 improved it a bit, but it's still clipped.

Comment 1

[arni2033]

Great, already reported. On DPI level 125% characters l,I,1 in the first line are indistinguishable
I pasted text from the page:   data:,for(I=0, l=i=1; I<l; I+=i){%0A  console.log("Hello, world!");%0A}

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: MozReview Request: Bug 1272999 - fixing multiline text clipping in console on Windows. r=bgrins

Review commit: https://reviewboard.mozilla.org/r/53566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53566/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8753921 [details]
MozReview Request: Bug 1272999 - fixing multiline text clipping in console on Windows. r=bgrins

https://reviewboard.mozilla.org/r/53566/#review50408

Works for me (haven't tested this locally on Windows so I trust you've do so).  Otherwise, we can request a confirmation that the issue is fixed after landing

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Just in case ill test the build once more https://treeherder.mozilla.org/#/jobs?repo=try&revision=12b9a1c078ed

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28176df6d571

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/28176df6d571

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 49.0a1 (2016-05-15) on Windows 8 , 64 Bit !

This bug's fix is verified with latest Beta 
 
Build ID   20160829102229
User Agent Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

[bugday-20160831]

Comment 8

[Rezaul Huque Nayeem]

Reproduced this bug in firefox nightly 49.0a1 (2016-05-15) with Ubuntu 16.04 (64 bit)

Verified this bug as fixed with latest firefox nightly 49.0b8 (Build ID: 20160829102229)
Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

As it is also verified on Windows (Comment 7), Marking it as verified