Move CompositorThreadHolder into its own file

RESOLVED FIXED in Firefox 49

Status

()

Core
Graphics: Layers
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(3 attachments)

A bunch of files include CompositorBridgeParent just to access the compositor message loop. To make it less tempting to use this class for random stuff, I'd like to split CompositorThreadHolder into its own file and move the message loop access there.
Created attachment 8752633 [details] [diff] [review]
part 1, separate file

Move CompositorThreadHolder into a separate file, and fix up callers to GetCompositorThreadHolder.

This (and the following patches) should all preserve existing behavior.
Attachment #8752633 - Flags: review?(matt.woodrow)
Created attachment 8752634 [details] [diff] [review]
part 2, move CompositorLoop()
Attachment #8752634 - Flags: review?(matt.woodrow)
Created attachment 8752635 [details] [diff] [review]
part 3, move IsInCompositorThread()
Attachment #8752635 - Flags: review?(matt.woodrow)
Attachment #8752633 - Flags: review?(matt.woodrow) → review+
Attachment #8752634 - Flags: review?(matt.woodrow) → review+
Attachment #8752635 - Flags: review?(matt.woodrow) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f18799f8f8c6
https://hg.mozilla.org/mozilla-central/rev/79da877c9d70
https://hg.mozilla.org/mozilla-central/rev/d869cb9a9e09
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1273949
You need to log in before you can comment on or make changes to this bug.