1273054 - "mach build faster" always invokes "mach artifact install"

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Of the 8 seconds "mach build faster" took to complete, 6 of those seconds was running "mach artifact install". It seems there should be no reason to install artifacts in this case as it is reasonable to insist that people switching to a different base revision should use plain old "mach build" to ensure the artifacts are up to date, leaving "mach build faster" to just update the non-binary parts of the build (possibly after a fast cursory check that *any* artifact is installed)

(On Windows using cinnabar, incase that's relevant)

> $ ./mach build faster
>  0:00.50 c:\mozilla-build\mozmake\mozmake.EXE -C o:/src/moz/gecko/obj-release -j12 -s backend
>  0:00.63 Running |mach artifact install|.
>  0:00.64 C:/mozilla-build/msys/bin/sh.exe -c o:/src/moz/gecko/mach artifact install
>  <snip many many lines like the 2 below>
>  0:04.64 Not updating o:/src/moz/gecko/obj-release/dist/bin/wow_helper.exe
>  0:05.03 Not updating o:/src/moz/gecko/obj-release/dist/bin/xul.dll
>  0:05.91 c:\mozilla-build\mozmake\mozmake.EXE -C faster -j12 -s
>  0:06.00 source-repo.h
> ...
> updated 2423; Removed 0 files and 0 directories.
>  0:07.92 Your build was successful!
> To view resource usage of the build, run |mach resource-usage|.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: MozReview Request: Bug 1273054 - skip performing artifact installs for 'mach build faster'. r?Gps

Review commit: https://reviewboard.mozilla.org/r/54778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54778/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8755743 [details]
MozReview Request: Bug 1273054 - skip performing artifact installs for 'mach build faster'. r?Gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54778/diff/1-2/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8755743 [details]
MozReview Request: Bug 1273054 - skip performing artifact installs for 'mach build faster'. r?Gps

https://reviewboard.mozilla.org/r/54778/#review54402

This is a reluctant r+: I'd rather make artificat install no-op faster. But this is the low-hanging fruit.

Comment 4

[Michael Shal [:mshal]]

I am also planning to change this code as part of bug 1275111. I think once landed that would also fix this issue, but I'm currently hitting bug 1277841 so I can't test for sure.

Just a heads up - I'll try to double-check when I can to make sure this isn't re-broken.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

(In reply to Michael Shal [:mshal] from comment #4)
> I am also planning to change this code as part of bug 1275111. I think once
> landed that would also fix this issue, but I'm currently hitting bug 1277841
> so I can't test for sure.
> 
> Just a heads up - I'll try to double-check when I can to make sure this
> isn't re-broken.

Thanks! It looks like that bug is active and will indeed fix the same issue (or at least break it such that a new patch would be needed anyway ;) so I might just wait a week or so and if that looks like landing I'll close this WFM.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Bug 1275111 also fixed this - thanks!