Closed Bug 1273063 Opened 6 years ago Closed 6 years ago

ChannelMediaResource::mIsTransportSeekable could be inconsistent with MediaCacheStream::mIsTransportSeekable

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

ChannelMediaResource::mIsTransportSeekable is added in bug 836927 which could be inconsistent with MediaCacheStream::mIsTransportSeekable after ChannelMediaResource::CanClone() because it is not copied but only set in ChannelMediaResource::OnStartRequest().

Hi Chris,
Is there any reason for ChannelMediaResource::IsTransportSeekable() not to just return mCacheStream.IsTransportSeekable()?
Blocks: 1272731
Flags: needinfo?(cpearce)
(In reply to JW Wang [:jwwang] from comment #0)
> Is there any reason for ChannelMediaResource::IsTransportSeekable() not to
> just return mCacheStream.IsTransportSeekable()?

I can't recall any reason why we could not do that. On the face of it, it seems like a good idea.
Flags: needinfo?(cpearce)
Comment on attachment 8753632 [details]
MozReview Request: Bug 1273063 - remove ChannelMediaResource::mIsTransportSeekable. r=cpearce.

https://reviewboard.mozilla.org/r/53422/#review50202

What could possibly go wrong...
Attachment #8753632 - Flags: review?(cpearce) → review+
Thanks!
Assignee: nobody → jwwang
https://hg.mozilla.org/mozilla-central/rev/246ada2a36af
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.