ChannelMediaResource::mIsTransportSeekable could be inconsistent with MediaCacheStream::mIsTransportSeekable

RESOLVED FIXED in Firefox 49

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
ChannelMediaResource::mIsTransportSeekable is added in bug 836927 which could be inconsistent with MediaCacheStream::mIsTransportSeekable after ChannelMediaResource::CanClone() because it is not copied but only set in ChannelMediaResource::OnStartRequest().

Hi Chris,
Is there any reason for ChannelMediaResource::IsTransportSeekable() not to just return mCacheStream.IsTransportSeekable()?
(Assignee)

Updated

2 years ago
Blocks: 1272731
(Assignee)

Updated

2 years ago
Flags: needinfo?(cpearce)
(In reply to JW Wang [:jwwang] from comment #0)
> Is there any reason for ChannelMediaResource::IsTransportSeekable() not to
> just return mCacheStream.IsTransportSeekable()?

I can't recall any reason why we could not do that. On the face of it, it seems like a good idea.
Flags: needinfo?(cpearce)
(Assignee)

Comment 2

2 years ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f85522ba657
(Assignee)

Comment 3

2 years ago
Created attachment 8753632 [details]
MozReview Request: Bug 1273063 - remove ChannelMediaResource::mIsTransportSeekable. r=cpearce.

Review commit: https://reviewboard.mozilla.org/r/53422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53422/
Attachment #8753632 - Flags: review?(cpearce)
Comment on attachment 8753632 [details]
MozReview Request: Bug 1273063 - remove ChannelMediaResource::mIsTransportSeekable. r=cpearce.

https://reviewboard.mozilla.org/r/53422/#review50202

What could possibly go wrong...
Attachment #8753632 - Flags: review?(cpearce) → review+
(Assignee)

Comment 5

2 years ago
Thanks!
Assignee: nobody → jwwang

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/246ada2a36af
https://hg.mozilla.org/mozilla-central/rev/246ada2a36af
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.