Closed Bug 1273123 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized scalar field] In constructor nsPresState

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1361786)

Attachments

(1 file)

The Static Analysis tool Coverity added that variable |mRestoringHistoryScrollPosition| is uninitialized. As we are trying to push for a more RAII architecture and we want to prepare our code for this clang-plugin - 525063. We should initialize these member variables.
(In reply to Andi-Bogdan Postelnicu from comment #0)
> As we are trying to push

Who is "we"?

> for a more RAII architecture

How is this relevant?

> and we want to prepare our code for this
> clang-plugin - 525063.

Is that a bug number?  If so, I can't access it.
Comment on attachment 8752779 [details]
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

https://reviewboard.mozilla.org/r/52800/#review49734

This member variable is unused.  Instead of initializing it, you should remove it.
Attachment #8752779 - Flags: review?(dbaron)
Comment on attachment 8752779 [details]
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52800/diff/1-2/
Attachment #8752779 - Attachment description: MozReview Request: Bug 1273123 - initialize mRestoringHistoryScrollPosition. r?dbaron → MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron
Attachment #8752779 - Flags: review?(dbaron)
(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) from comment #2)
> (In reply to Andi-Bogdan Postelnicu from comment #0)
> > As we are trying to push
> 
> Who is "we"?
> 
I'm part of of release management team and i'm currently trying to fix different issues triggered by different static analyssi tools, such as coverity, scan-build, infer, etc. 
> > for a more RAII architecture
> 
> How is this relevant?
> 
> > and we want to prepare our code for this
> > clang-plugin - 525063.
> 
> Is that a bug number?  If so, I can't access it.

Yes it is a bug number but it was marked as security issue and that's why you were unable to open it, I've added you to the cc list.
Comment on attachment 8752779 [details]
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

https://reviewboard.mozilla.org/r/52800/#review50036
Attachment #8752779 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/8b9e82bf88a9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.