Closed
Bug 1273123
Opened 5 years ago
Closed 5 years ago
[Static Analysis][Uninitialized scalar field] In constructor nsPresState
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1361786)
Attachments
(1 file)
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron
58 bytes,
text/x-review-board-request
|
dbaron
:
review+
|
Details |
The Static Analysis tool Coverity added that variable |mRestoringHistoryScrollPosition| is uninitialized. As we are trying to push for a more RAII architecture and we want to prepare our code for this clang-plugin - 525063. We should initialize these member variables.
Assignee | ||
Comment 1•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/52800/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/52800/
Attachment #8752779 -
Flags: review?(dbaron)
Comment 2•5 years ago
|
||
(In reply to Andi-Bogdan Postelnicu from comment #0) > As we are trying to push Who is "we"? > for a more RAII architecture How is this relevant? > and we want to prepare our code for this > clang-plugin - 525063. Is that a bug number? If so, I can't access it.
Comment 3•5 years ago
|
||
Comment on attachment 8752779 [details] MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron https://reviewboard.mozilla.org/r/52800/#review49734 This member variable is unused. Instead of initializing it, you should remove it.
Attachment #8752779 -
Flags: review?(dbaron)
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 8752779 [details] MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52800/diff/1-2/
Attachment #8752779 -
Attachment description: MozReview Request: Bug 1273123 - initialize mRestoringHistoryScrollPosition. r?dbaron → MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron
Attachment #8752779 -
Flags: review?(dbaron)
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) from comment #2) > (In reply to Andi-Bogdan Postelnicu from comment #0) > > As we are trying to push > > Who is "we"? > I'm part of of release management team and i'm currently trying to fix different issues triggered by different static analyssi tools, such as coverity, scan-build, infer, etc. > > for a more RAII architecture > > How is this relevant? > > > and we want to prepare our code for this > > clang-plugin - 525063. > > Is that a bug number? If so, I can't access it. Yes it is a bug number but it was marked as security issue and that's why you were unable to open it, I've added you to the cc list.
Comment 6•5 years ago
|
||
Comment on attachment 8752779 [details] MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron https://reviewboard.mozilla.org/r/52800/#review50036
Attachment #8752779 -
Flags: review?(dbaron) → review+
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8b9e82bf88a9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•