1273123 - [Static Analysis][Uninitialized scalar field] In constructor nsPresState

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andi-Bogdan Postelnicu [:andi]]

The Static Analysis tool Coverity added that variable |mRestoringHistoryScrollPosition| is uninitialized. As we are trying to push for a more RAII architecture and we want to prepare our code for this clang-plugin - 525063. We should initialize these member variables.

Comment 1

[Andi-Bogdan Postelnicu [:andi]]

Attachment: MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

Review commit: https://reviewboard.mozilla.org/r/52800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52800/

Comment 2

[David Baron :dbaron:]

(In reply to Andi-Bogdan Postelnicu from comment #0)
> As we are trying to push

Who is "we"?

> for a more RAII architecture

How is this relevant?

> and we want to prepare our code for this
> clang-plugin - 525063.

Is that a bug number?  If so, I can't access it.

Comment 3

[David Baron :dbaron:]

Comment on attachment 8752779 [details]
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

https://reviewboard.mozilla.org/r/52800/#review49734

This member variable is unused.  Instead of initializing it, you should remove it.

Comment 4

[Andi-Bogdan Postelnicu [:andi]]

Comment on attachment 8752779 [details]
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52800/diff/1-2/

Comment 5

[Andi-Bogdan Postelnicu [:andi]]

(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) from comment #2)
> (In reply to Andi-Bogdan Postelnicu from comment #0)
> > As we are trying to push
> 
> Who is "we"?
> 
I'm part of of release management team and i'm currently trying to fix different issues triggered by different static analyssi tools, such as coverity, scan-build, infer, etc. 
> > for a more RAII architecture
> 
> How is this relevant?
> 
> > and we want to prepare our code for this
> > clang-plugin - 525063.
> 
> Is that a bug number?  If so, I can't access it.

Yes it is a bug number but it was marked as security issue and that's why you were unable to open it, I've added you to the cc list.

Comment 6

[David Baron :dbaron:]

Comment on attachment 8752779 [details]
MozReview Request: Bug 1273123 - removed unused variable |mRestoringHistoryScrollPosition|. r?dbaron

https://reviewboard.mozilla.org/r/52800/#review50036

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b9e82bf88a9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b9e82bf88a9