1273128 - [Static Analysis][Dereference before null check] In function nsMenuBarListener::KeyPress

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variable |nativeKeyEvent| is derefernced before being null checked. 

dereference:

>>    // If accesskey handling was forwarded to a child process, wait for
>>    // the mozaccesskeynotfound event before handling accesskeys.
>>    WidgetKeyboardEvent* nativeKeyEvent =
>>      aKeyEvent->WidgetEventPtr()->AsKeyboardEvent();
>>    if (nativeKeyEvent->mAccessKeyForwardedToChild) {
>>      return NS_OK;
>>    }

null-check:

>>    bool hasAccessKeyCandidates = charCode != 0;
>>    if (!hasAccessKeyCandidates) {
>>      if (nativeKeyEvent) {
>>        AutoTArray<uint32_t, 10> keys;
>>        nativeKeyEvent->GetAccessKeyCandidates(keys);
>>        hasAccessKeyCandidates = !keys.IsEmpty();
>>      }
>>    }

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1273128 - prevent null pointer dereference on |nativeKeyEvent|. r?janv

Review commit: https://reviewboard.mozilla.org/r/52804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52804/

Comment 2

[Jan Varga [:janv]]

Comment on attachment 8752817 [details]
MozReview Request: Bug 1273128 - prevent null pointer dereference on |nativeKeyEvent|. r?janv

https://reviewboard.mozilla.org/r/52804/#review51428

r=me

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2cfd126f1e5

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2cfd126f1e5