Delay networkid calculation to reduce failure rate

RESOLVED FIXED in Firefox 49

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bagder, Assigned: bagder)

Tracking

unspecified
mozilla49
Unspecified
Linux
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Make sure we run the calculateNetworkId function only once per change and at the end of the coalescing period. That will not only avoid multiple invokes but also allow the system a full extra second to use the gateway and thus populate the ARP cache.
(Assignee)

Comment 1

2 years ago
Created attachment 8752865 [details] [diff] [review]
0001-bug-1273165-sync-networkid-calculation-with-the-even.patch

My hope is that this will decrease the networkid failure rate somewhat. We will need other mitigations too, but this should still be the correct thing to do.
Assignee: nobody → daniel
Status: NEW → ASSIGNED
Attachment #8752865 - Flags: review?(mcmanus)
(Assignee)

Updated

2 years ago
Whiteboard: [necko-active]
Attachment #8752865 - Flags: review?(mcmanus) → review+
(Assignee)

Comment 2

2 years ago
It builds fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcd696bbccba
Keywords: checkin-needed

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/be9358f86e3a
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/be9358f86e3a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.