1273171 - Add some missing members to imIncomingServer class.

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Comment 1

[Patrick Cloke [:clokep]]

Can you please provide a longer description about what this bug fixes? Thanks.

Comment 2

[alta88]

Attachment: Add some missing members to imIncomingServer class

For completeness, imIncomingServer should have these 2 properties. It may not throw in the current usage, but does on a custom folderpane implementation I'm doing.

Btw, the im js incomingServer implementation is a great model; why it's not being used in favor of more c++ xpcom deadwood (seriously, worrying about gc for custom accounts ??) is a mystery.

Comment 3

[alta88]

(In reply to Patrick Cloke [:clokep] from comment #1)
> Can you please provide a longer description about what this bug fixes?
> Thanks.

That was so fast I hadn't yet attached the patch to the placeholder bug ;)

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8752880 [details] [diff] [review]
Add some missing members to imIncomingServer class

Review of attachment 8752880 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Can you change the commit message to say "imIncomingServer's nsIMsgFolder implementation" instead of "imIncomingServer class"?

::: mail/components/im/imIncomingServer.js
@@ +249,5 @@
>        get subFolders() { return EmptyEnumerator; },
>        getStringProperty: aPropertyName => "",
>        getNumUnread: aDeep => 0,
>        Shutdown: function() {},
> +      get URI() { return this.server.serverURI; },

nit: I would move this getter to be right before "get prettyName()" so that the order here is more consistent with the order in the nsIMsgFolder.idl file.

Comment 5

[alta88]

Attachment: imIncomingServer.patch

thanks, udpated for comment.

Comment 6

[:aceman]

I was going to check this is, but why is the author (User) in the patch named as aleth? Shouldn't it be alta88?

Comment 7

[alta88]

Attachment: imIncomingServer.patch

Comment 8

[alta88]

no idea how that happened, but the 2nd one is correct.

Comment 9

[:aceman]

https://hg.mozilla.org/comm-central/rev/b9e288fb22c50c41103107be28329b370852ebc0