Closed Bug 1273173 Opened 4 years ago Closed 4 years ago

UI Telemetry bustage due to bad patch

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: mfinkle, Assigned: Margaret)

References

Details

Attachments

(1 file)

Bug 1266163 landed some UI Telemetry probes for Reader, converting from histograms. The patch had a problem. The code uses:

UITelemetry.addEvent("action.1", "button", "reader_exit");

But that passes the string "reader_exit" as Timestamp, which is the real 3rd param. Passing a String to a field that expects a Long breaks the Python ETL scripts and wastes the event since we lose the real timestamp.

I can update the ETL scripts to check and ignore this type of invalid record, but the code needs to be fixed ro we'll never see these events in the DB.
I noticed this while working on bug 1268104, I need to fix it.
Assignee: nobody → margaret.leibovic
Blocks: 1266163
Comment on attachment 8753177 [details]
MozReview Request: Bug 1273173 - Fix reader button telemetry events. r=mcomella

https://reviewboard.mozilla.org/r/53060/#review50172

lgtm
Attachment #8753177 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/64ad4c149ac0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.