Closed Bug 1273190 Opened 4 years ago Closed 4 years ago

Fix indentation in some xpcom/ files

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(4 files)

I realized I couldn't get too much on a high horse about other people not using the standard Mozilla style if parts of the code base I care about don't use it, so I decided to fix up some 4-space indentations in XPCOM code that were identified by my modeline fixing and analysis script.
This fixes up a few random files. xpcom/tests/, xpcom/tests/static-checker/, xpcom/tests/windows/, xpcom/typelib/xpt/, xpcom/typelib/xpt/tests/ and everything under xpcom/reflect are still blacklisted in my modeline script. In addition, I didn't feel up to fixing xpcom/glue/nsQuickSort.cpp or xpcom/base/nsAgg.h.
It looks like xpcom/tests/static-checker/ and xpcom/typelib/xpt/tests/ don't exist any more.
Autogenerated by modeline.py.
Attachment #8752974 - Flags: review?(nfroyd)
Attached patch part 1 with -wSplinter Review
Attachment #8752976 - Flags: checkin-
Attachment #8752976 - Attachment description: part w with -w → part 1 with -w
Comment on attachment 8752972 [details] [diff] [review]
part 1 - Fix indentation and mode lines for various xpcom/ files.

Review of attachment 8752972 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/components/ModuleUtils.h
@@ +42,4 @@
>                                                                                \
> +  inst = new _InstanceClass();                                                \
> +  rv = inst->_InitMethod();                                                   \
> +  if(NS_SUCCEEDED(rv)) {                                                      \

Nit: can you add a space after the |if|, since you're already changing the line?
Attachment #8752972 - Flags: review?(nfroyd) → review+
Attachment #8752973 - Flags: review?(nfroyd) → review+
Attachment #8752974 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #7)
> Nit: can you add a space after the |if|, since you're already changing the line?

Fixed.
Oops, I thought I landed that, but I guess the tree was closed.
You need to log in before you can comment on or make changes to this bug.