127321 - option-right-arrow moving between words stops at punctuation

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Chris Andrichak]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.8) Gecko/20020204
BuildID:    2002020405

if you use option-right-arrow to move from word to word in
the compose window (HTML compose) you get 'stuck' at punctuation
marks. The cursor won't go any further. using option-left-arrow seems
to work ok.

Reproducible: Always
Steps to Reproduce:
1.compose and HTML mail
2.use option--right-arrow to move around
3.

Comment 1

[Jean-Francois Ducarroz]

over to editor

Comment 2

[kinmoz]

--> mjudge (selection/caret navigation)

Comment 3

[Kathleen :Brade]

This may be affected by a pref introduced by pinkerton (so it may not appear on
Windows?).

Pink--Mike will probably need to know the pref; do you know what it is?

Comment 4

[Mike Pinkerton (not reading bugmail)]

i think one of the prefs is 

layout.word_select.stop_at_punctuation

but it should be pretty easy to find them in the code.

Comment 5

[Nick Baker]

I'll add that this also occurs in text boxes in Navigator (such as the one I'm
typing in now ...). Also, the cursor gets stuck on every non-alphnumeric
character I've thrown at it (parentheses, plus sign, dash, period, etc.). I'm
using build 2002032808.

Comment 6

[Kathleen :Brade]

*** Bug 137754 has been marked as a duplicate of this bug. ***

Comment 7

[Mike Pinkerton (not reading bugmail)]

basic keyboard accessiblity. can't ship w/out this fixed.

Comment 8

[saari (gone)]

I didn't even know you could do that in any editor... so I'm not sure I agree
with the basic functionality assessment. If it is a regression I'm inclined to
make it EDITORBASE+ however.

Comment 9

[Mike Pinkerton (not reading bugmail)]

hello? every text field on macos has done that since 1984. 

Comment 10

[saari (gone)]

<shrug> Okay. Is it a regression for us?

Comment 11

[Kathleen :Brade]

Yes, this is a regression; the regression keyword is already defined in the
keywords section.

Comment 12

[Kevin McCluskey (gone)]

editorbase triage: EDITORBASE-. leaving topembed+

Comment 13

[saari (gone)]

Kevin, this is a regression and a lot of people are noticing it. Are we sure 
this is a minus?

Comment 14

[mjudge]

*** Bug 141909 has been marked as a duplicate of this bug. ***

Comment 15

[timeless]

*** Bug 148374 has been marked as a duplicate of this bug. ***

Comment 16

[Kathleen :Brade]

seeking reconsideration on this; it's very wrong and should be fixed

Comment 17

[Kevin McCluskey (gone)]

EDITORBASE+

Comment 18

[Tuukka Tolvanen (sp3000)]

is this not bug 108125?

Comment 19

[mjudge]

ok the WRONG part is that you get STUCK on the punctuation? I mean you cant 
advance any further by word jumping when you hit a punctuation or that you 
shouldnt even stop at the punctuation at all.  I just need some hints.

Comment 20

[Kathleen :Brade]

Mike--the problem is that you can't continue moving the caret with that
keybinding.  Once I hit that punctuation, I expect to be able to continue to
option-right-arrow to get to the next word.

Comment 21

[mjudge]

Attachment: ok this fixes skipping of multiple punctuation.

this looks good to me. and in a good place. if we are on punctuation, keep
reading in punctuation. if we are on alpha numerics keep reading until we hit
punctuation.

Comment 22

[Kathleen :Brade]

Comment on attachment 94245 [details] [diff] [review]
ok this fixes skipping of multiple punctuation.

can the local variable "readingAlNum" be changed to something more readable
such as "readingAlphaNumeric" or even better: "isReadingAlphaNumeric"?

Does this work with non-latin1 charset?

Comment 23

[mjudge]

Attachment: dif to fix skipping multiple punctuation. with new varname

changed readAlNum to readingAlphaNumeric.  the function that is changing is:
ScanNormalAsciiText_F_ForWordBreak which is not used by anything non ASCII.

Comment 24

[Kathleen :Brade]

Comment on attachment 94362 [details] [diff] [review]
dif to fix skipping multiple punctuation. with new varname

r=brade

Comment 25

[Simon Fraser [no longer active]]

Different editors behave differently w.r.t punctuation, and spaces. The current
patch treats runs of punctuation as 'words' and jumps them in 1 go. BBEdit on OS
9 goes 1 char at a time through punctuation; TextEdit on X skips runs of
punctuation. Some editors will skip single/multiple punc chars at the start of a
word.

Do we care?

Comment 26

[Simon Fraser [no longer active]]

Comment on attachment 94362 [details] [diff] [review]
dif to fix skipping multiple punctuation. with new varname

sr=sfraser

Comment 27

[:deanis74]

*** Bug 108125 has been marked as a duplicate of this bug. ***

Comment 28

[mjudge]

checked into trunk

Comment 29

[Simon Fraser [no longer active]]

I migrated this fix to the CHIMERA_M1_0_1_BRANCH too.

Comment 30

[S Woodside]

*** Bug 175387 has been marked as a duplicate of this bug. ***

Comment 31

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.02.19 (behavior the same on mac 10.2.4 and linux rh8.0).