1273275 - Align scrollIntoView with the WebDriver usage

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

currently we scroll to the end of the element but WebDriver scrolls to the top of the element.

We need to align this.

Comment 1

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1273275: scroll to the top of elements before interacting r?ato

This allows us to converge with webdriver project which scrolls to the
start of the element instead of the end.

Review commit: https://reviewboard.mozilla.org/r/52974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52974/

Comment 2

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=15263fb35407

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8753060 [details]
MozReview Request: Bug 1273275: scroll to the top of elements before interacting r?ato

https://reviewboard.mozilla.org/r/52974/#review49832

::: testing/marionette/element.js:847
(Diff revision 1)
>      return true;
>    }
>  
>    if (!element.inViewport(el, x, y)) {
>      if (el.scrollIntoView) {
> -      el.scrollIntoView(false);
> +      el.scrollIntoView(true);

Change to: `{block: "start", inline: "nearest"}`

Comment 4

[David Burns :automatedtester]

Comment on attachment 8753060 [details]
MozReview Request: Bug 1273275: scroll to the top of elements before interacting r?ato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52974/diff/1-2/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8e15442428

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bf8e15442428

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/35c64e20fc9a

Comment 8

[David Burns :automatedtester]

https://hg.mozilla.org/releases/mozilla-aurora/rev/35c64e20fc9a