Closed
Bug 1273275
Opened 8 years ago
Closed 8 years ago
Align scrollIntoView with the WebDriver usage
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: automatedtester, Assigned: automatedtester)
References
(Blocks 1 open bug)
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
currently we scroll to the end of the element but WebDriver scrolls to the top of the element. We need to align this.
Assignee | ||
Comment 1•8 years ago
|
||
This allows us to converge with webdriver project which scrolls to the start of the element instead of the end. Review commit: https://reviewboard.mozilla.org/r/52974/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/52974/
Attachment #8753060 -
Flags: review?(ato)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15263fb35407
Updated•8 years ago
|
Assignee: nobody → dburns
Keywords: ateam-marionette-server
Comment 3•8 years ago
|
||
Comment on attachment 8753060 [details] MozReview Request: Bug 1273275: scroll to the top of elements before interacting r?ato https://reviewboard.mozilla.org/r/52974/#review49832 ::: testing/marionette/element.js:847 (Diff revision 1) > return true; > } > > if (!element.inViewport(el, x, y)) { > if (el.scrollIntoView) { > - el.scrollIntoView(false); > + el.scrollIntoView(true); Change to: `{block: "start", inline: "nearest"}`
Attachment #8753060 -
Flags: review?(ato) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8753060 [details] MozReview Request: Bug 1273275: scroll to the top of elements before interacting r?ato Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52974/diff/1-2/
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bf8e15442428
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/35c64e20fc9a
status-firefox48:
--- → fixed
Assignee | ||
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/35c64e20fc9a
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•