Closed
Bug 1273288
Opened 8 years ago
Closed 8 years ago
mach web-platform-tests-create something.xhtml doesn't work right
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: jkt)
Details
Attachments
(1 file)
Running this: mach web-platform-tests-create something.xhtml doesn't work right doesn't add the new test to the manifest.
|
Reporter | |
Comment 1•8 years ago
|
||
Er, clearly the "doesn't work right" shouldn't be part of the command.... ;)
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58214/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58214/
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jkingston
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8760752 [details] Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible Hey :bz, This fixed creating files for me of different extensions. The proc var seemed to have the wrong nesting, I can't see any other use for it.
Attachment #8760752 -
Flags: review?(james)
|
|
Assignee | |
Comment 4•8 years ago
|
||
:bz was busy assigned to :jgraham sorry for not updating my comment :)
|
||
Updated•8 years ago
|
Attachment #8760752 -
Flags: review?(james)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8760752 [details] Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible https://reviewboard.mozilla.org/r/58214/#review55066 ::: testing/web-platform/mach_commands.py:228 (Diff revision 1) > else: > editor = None > > if editor: > proc = subprocess.Popen("%s %s" % (editor, path), shell=True) > + proc.wait() Not quite; the idea is to have the editor running in parallel with the next part. So I think you need to set `proc=None` and then leter check if `proc` was set.
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8760752 [details] Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58214/diff/1-2/
Attachment #8760752 -
Flags: review?(james)
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8760752 [details] Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible https://reviewboard.mozilla.org/r/58214/#review55070
Attachment #8760752 -
Flags: review?(james) → review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8760752 [details] Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58214/diff/2-3/
Attachment #8760752 -
Attachment description: Bug: 1273288 - Fix issue with undefined proc variable when editor isn't possible → Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible
|
||
Comment 10•8 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/a607886f98ae Fix issue with undefined proc variable when editor isn't possible r=jgraham
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a607886f98ae
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•