Closed Bug 1273288 Opened 4 years ago Closed 4 years ago

mach web-platform-tests-create something.xhtml doesn't work right

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bzbarsky, Assigned: jkt)

Details

Attachments

(1 file)

Running this:

  mach web-platform-tests-create something.xhtml doesn't work right

doesn't add the new test to the manifest.
Er, clearly the "doesn't work right" shouldn't be part of the command.... ;)
Assignee: nobody → jkingston
Comment on attachment 8760752 [details]
Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible

Hey :bz, This fixed creating files for me of different extensions.

The proc var seemed to have the wrong nesting, I can't see any other use for it.
Attachment #8760752 - Flags: review?(james)
:bz was busy assigned to :jgraham sorry for not updating my comment :)
Attachment #8760752 - Flags: review?(james)
Comment on attachment 8760752 [details]
Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible

https://reviewboard.mozilla.org/r/58214/#review55066

::: testing/web-platform/mach_commands.py:228
(Diff revision 1)
>          else:
>              editor = None
>  
>          if editor:
>              proc = subprocess.Popen("%s %s" % (editor, path), shell=True)
> +            proc.wait()

Not quite; the idea is to have the editor running in parallel with the next part. So I think you need to set `proc=None` and then leter check if `proc` was set.
Comment on attachment 8760752 [details]
Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58214/diff/1-2/
Attachment #8760752 - Flags: review?(james)
Comment on attachment 8760752 [details]
Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible

https://reviewboard.mozilla.org/r/58214/#review55070
Attachment #8760752 - Flags: review?(james) → review+
Comment on attachment 8760752 [details]
Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58214/diff/2-3/
Attachment #8760752 - Attachment description: Bug: 1273288 - Fix issue with undefined proc variable when editor isn't possible → Bug 1273288 - Fix issue with undefined proc variable when editor isn't possible
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a607886f98ae
Fix issue with undefined proc variable when editor isn't possible r=jgraham
https://hg.mozilla.org/mozilla-central/rev/a607886f98ae
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.