Closed Bug 1273324 Opened 4 years ago Closed 4 years ago

Permafailing Win64 xpcshell test_dmd.js | test - [test : 113] full-sampled-live - false == true

Categories

(Core :: JavaScript Engine, defect)

49 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox47 --- fixed
firefox48 --- unaffected
firefox49 --- unaffected

People

(Reporter: KWierso, Assigned: erahm)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

This has been permafailing on beta since bug 1181142 landed there ten days ago.

We've been starring this as bug 1239253 incorrectly for the entire time.

https://treeherder.mozilla.org/logviewer.html#?job_id=1066536&repo=mozilla-beta
Flags: needinfo?(erahm)
I'll take a look at this today.
Alright, windows has finally finished it's update and reboot death spiral, I have beta checked out and figured out how to build it. I should be able to fix this today.
Flags: needinfo?(erahm)
I think this is the fix. The test that was failing now passes locally, but another fails due to basic-scan.json being invalid json (we write windows paths which looks like weird escapes to the json parser). This might just be a quirk of my setup. When try comes back from the dead I'll do another push.
Attachment #8754541 - Flags: review?(n.nethercote)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8754541 [details] [diff] [review]
Fix dmd test on mozilla-beta

Review of attachment 8754541 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for looking into this. This change looks good. Another option that might be simpler is to just disable the test entirely on Beta, which I'd be ok with.
Attachment #8754541 - Flags: review?(n.nethercote) → review+
This landed on 5/20: https://hg.mozilla.org/releases/mozilla-beta/rev/bb07b5227ff1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.