Closed
Bug 1273353
Opened 8 years ago
Closed 8 years ago
Unable to tap on the links or buttons on the reported attack page UI
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox47 unaffected, firefox48+ verified, firefox49+ verified, fennec48+)
VERIFIED
FIXED
Firefox 49
People
(Reporter: kbrosnan, Assigned: gcp)
References
Details
(Keywords: regression)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
francois
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
* Open http://www.itisatrap.org/firefox/its-an-attack.html * Attempt to use the 'Get me out of here!' or 'Why was this page blocked?' button * Attempt to use the 'Ignore this warning' link Expected: buttons/links should navigate to a resource Actual: buttons/links do not function This is a regression in Firefox 48
Reporter | ||
Comment 1•8 years ago
|
||
The deceptive site UI is affected as well http://www.itisatrap.org/firefox/its-a-trap.html
Reporter | ||
Updated•8 years ago
|
tracking-firefox47:
? → ---
tracking-firefox49:
--- → ?
Assignee | ||
Comment 3•8 years ago
|
||
15:52.58 INFO: Last good revision: f43c0ea2c7c847ca361375164b3a4c58eb714426 15:52.58 INFO: First bad revision: 47162e3a9e0262b29af5dbb43ce1fa51dc3a31a5 15:52.58 INFO: Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f43c0ea2c7c847ca361375164b3a4c58eb714426&tochange=47162e3a9e0262b29af5dbb43ce1fa51dc3a31a5 15:53.76 INFO: Looks like the following bug has the changes which introduced the regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1103588
Depends on: 1103588
Assignee | ||
Updated•8 years ago
|
Keywords: regressionwindow-wanted
Assignee | ||
Comment 4•8 years ago
|
||
https://dxr.mozilla.org/mozilla-central/rev/a884b96685aa13b65601feddb24e5f85ba861561/mobile/android/chrome/content/browser.js#
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53294/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53294/
Attachment #8753462 -
Flags: review?(francois)
Comment 6•8 years ago
|
||
Comment on attachment 8753462 [details] MozReview Request: Bug 1273353 - Replace usage of deprecated JS String.proto.contains(). r?francois https://reviewboard.mozilla.org/r/53294/#review50084
Attachment #8753462 -
Flags: review?(francois) → review+
Updated•8 years ago
|
Assignee: nobody → gpascutto
Status: NEW → ASSIGNED
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d5a0d32b699
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8753462 [details] MozReview Request: Bug 1273353 - Replace usage of deprecated JS String.proto.contains(). r?francois Approval Request Comment [Feature/regressing bug #]: Bug 1103588 [User impact if declined]: No way to bypass SafeBrowsing warning pages [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Very low, simple substitution, can't really affect other stuff [String/UUID change made/needed]:
Attachment #8753462 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 10•8 years ago
|
||
Is this a pattern we should search the codebase for and file bugs for?
tracking-fennec: ? → 48+
Assignee | ||
Comment 11•8 years ago
|
||
I understand from the linked bug that we made Firefox spew warnings when usage of this pattern is detected, but that's obviously not very helpful on Android, and was hence not caught. I'm also a slightly surprised that our tests didn't catch it, not sure if the relevant test is disabled on Android or it simply doesn't check this usage pattern.
Comment 12•8 years ago
|
||
Comment on attachment 8753462 [details] MozReview Request: Bug 1273353 - Replace usage of deprecated JS String.proto.contains(). r?francois Fix a regression, taking it.
Attachment #8753462 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/da19ad7ec3e1
Comment 14•8 years ago
|
||
Tapping 'Get me out of here!', 'Why was this page blocked?' or Ignore this warning' works ok, so: Verified as fixed using: Device: One A2001 (Android 5.1.1) Build: Firefox for Android 49.0a1 (2016-05-29)
Comment 15•8 years ago
|
||
Verified as fixed also using: Device: One A2001 (Android 5.1.1) Build: Firefox for Android 48.0a2 (2016-05-29)
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•