Closed
Bug 1273356
Opened 8 years ago
Closed 8 years ago
Rip out the ComputeRenderIntegrity function and friends
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
This function used to be used for computing checkerboarding with the Java PZC. We don't use it for anything else, I think. And even the checkerboarding talos tests have been disabled for a while, so we should just rip all this out.
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [gfx-noted]
|
Assignee | |
Comment 1•8 years ago
|
||
I'm in the mood to delete some code.
Assignee: nobody → bugmail
status-firefox49:
affected → ---
status-firefox50:
--- → wontfix
status-firefox51:
--- → affected
Version: Trunk → 49 Branch
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68656/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68656/
Attachment #8777059 -
Flags: review?(rbarker)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8777059 [details] Bug 1273356 - Remove the unused and incorrect ComputeRenderIntegrity codepath for computing checkerboard. https://reviewboard.mozilla.org/r/68656/#review65724
Attachment #8777059 -
Flags: review?(rbarker) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/238564059ef3 Remove the unused and incorrect ComputeRenderIntegrity codepath for computing checkerboard. r=rbarker
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6849935c81c6 Backed out changeset 238564059ef3 for Android 4.3 debug failed to load manufest file
|
||
Comment 6•8 years ago
|
||
Sorry had to backout your push because Android 4.3 debug failed to load manifest file, e.g., https://treeherder.mozilla.org/logviewer.html#?job_id=1333633&repo=autoland#L595
Flags: needinfo?(bugmail)
|
|
Assignee | |
Comment 7•8 years ago
|
||
(In reply to Iris Hsiao [:ihsiao] from comment #6) > Sorry had to backout your push because Android 4.3 debug failed to load > manifest file, e.g., > https://treeherder.mozilla.org/logviewer. > html#?job_id=1333633&repo=autoland#L595 gbrown said this failure was likely his fault, and filed bug 1291710 for the issue that caused it. I'm waiting on a couple of job retriggers to confirm his theory, and if they are green I will reland the patch.
Flags: needinfo?(bugmail)
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/173cab86c3e0 Remove the unused and incorrect ComputeRenderIntegrity codepath for computing checkerboard. r=rbarker
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/173cab86c3e0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•