Closed Bug 1273357 Opened 8 years ago Closed 8 years ago

TPS should log the SOURCE_REVISION_URL and platform

Categories

(Testing Graveyard :: TPS, defect)

Version 3
defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: markh, Unassigned)

Details

Attachments

(1 file)

TPS will be running from Nightlies, but it's slightly tricky to determine exactly what hg revision it is using. If TPS logged SOURCE_REVISION_URL as it started this would be clear. It also might as well log the platform being run in anticipation of the day that all platforms are tested.
Comment on attachment 8753155 [details]
MozReview Request: Bug 1273357 - have TPS log SOURCE_REVISION_URL and the platform it is running on. r?tcsc

https://reviewboard.mozilla.org/r/53044/#review50012

Looks fine assuming the question below isn't an issue.

::: services/sync/tps/extensions/tps/resource/tps.jsm:664
(Diff revision 1)
>  
>        Logger.init(logpath);
>        Logger.logInfo("Sync version: " + WEAVE_VERSION);
>        Logger.logInfo("Firefox buildid: " + Services.appinfo.appBuildID);
>        Logger.logInfo("Firefox version: " + Services.appinfo.version);
> +      Logger.logInfo("Firefox source revision: " + (AppConstants.SOURCE_REVISION_URL || "unknown"));

AppConstants.jsm indicates that this is an empty string for unofficial builds, are the cases where we care about this always official?
Attachment #8753155 - Flags: review?(tchiovoloni) → review+
Thanks!

(In reply to Thom Chiovoloni [:tcsc] from comment #2)
> AppConstants.jsm indicates that this is an empty string for unofficial
> builds, are the cases where we care about this always official?

Yeah, TPS in automation is always going to be run by downloaded builds for the time being - although if there was a way to get the revision from *all* builds I would have preferred that, but I don't think there is.
https://hg.mozilla.org/mozilla-central/rev/cb66e2880961
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: