Closed
Bug 1273360
Opened 8 years ago
Closed 8 years ago
Crash in nsStyleMargin::GetMarginNoPercentage
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1272983
Tracking | Status | |
---|---|---|
firefox49 | --- | affected |
People
(Reporter: n.nethercote, Unassigned)
Details
(Keywords: crash)
Crash Data
This bug was filed from the Socorro interface and is report bp-af1dfec5-f96e-4375-8801-34dca2160512. ============================================================= This crash first appeared in Nightly 20160506052823, and has happened 12 times since then. About half crash at address 0x0, and half at 0x7ffd00000000 or somewhere close to that. > 0 xul.dll nsStyleMargin::GetMarginNoPercentage(nsMargin&) layout/style/nsStyleStruct.h:845 > 1 xul.dll nsIFrame::GetUsedMargin() layout/generic/nsFrame.cpp:969 > 2 xul.dll nsIFrame::GetLogicalUsedMargin(mozilla::WritingMode) layout/generic/nsIFrame.h:967 > 3 xul.dll nsBidiPresUtils::RepositionFrame(nsIFrame*, bool, int, nsTHashtable<nsFrameContinuationState> const*, mozilla::WritingMode, bool, nsSize const&) layout/base/nsBidiPresUtils.cpp:1568 > 4 xul.dll nsBidiPresUtils::RepositionInlineFrames(BidiLineData*, mozilla::WritingMode, nsSize const&, int) layout/base/nsBidiPresUtils.cpp:1691 > 5 xul.dll nsBidiPresUtils::ReorderFrames(nsIFrame*, int, mozilla::WritingMode, nsSize const&, int) layout/base/nsBidiPresUtils.cpp:1276 > 6 xul.dll nsLineLayout::TextAlignLine(nsLineBox*, bool) layout/generic/nsLineLayout.cpp:3239 > 7 xul.dll nsBlockFrame::PlaceLine(nsBlockReflowState&, nsLineLayout&, nsLineList_iterator, nsFloatManager::SavedState*, mozilla::LogicalRect&, int&, bool*) layout/generic/nsBlockFrame.cpp:4507 > 8 xul.dll nsBlockFrame::DoReflowInlineFrames(nsBlockReflowState&, nsLineLayout&, nsLineList_iterator, nsFlowAreaRect&, int&, nsFloatManager::SavedState*, bool*, LineReflowStatus*, bool) layout/generic/nsBlockFrame.cpp:4016 > 9 xul.dll nsBlockFrame::ReflowInlineFrames(nsBlockReflowState&, nsLineList_iterator, bool*) layout/generic/nsBlockFrame.cpp:3755 > 10 xul.dll nsBlockFrame::ReflowLine(nsBlockReflowState&, nsLineList_iterator, bool*) layout/generic/nsBlockFrame.cpp:2753 bholley, you've touched this code recently. Can you please take a look? Could bug 1269901 be involved?
Flags: needinfo?(bobbyholley)
Updated•8 years ago
|
Crash Signature: [@ nsStyleMargin::GetMarginNoPercentage] → [@ nsStyleMargin::GetMarginNoPercentage]
[@ xul.dll@0x31b103]
Comment 1•8 years ago
|
||
dholbert has a patch for this which he'll land shortly. Thanks dholbert!
Flags: needinfo?(bobbyholley) → needinfo?(dholbert)
Comment 2•8 years ago
|
||
Just landed patches that should fix this, over on bug 1272983. Duping to that bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(dholbert)
Resolution: --- → DUPLICATE
Reporter | ||
Comment 3•8 years ago
|
||
I see 10 occurrences of this in Nightly 20160520030251 and zero in Nightly 20160521030227. Good.
Comment 4•8 years ago
|
||
bug 1272983's patches (which fix this bug) aren't actually in Nightlies yet. (Looks like no inbound csets since Friday 5/20 afternoon [california time] have been merged to central). I expect there will be a merge today, though, and this'll be fixed in tomorrow's nightly.
You need to log in
before you can comment on or make changes to this bug.
Description
•