127337 - Restore Default for Home Page button

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Rafael Ebron (:rebron)]

Navigator--> Homepage Pref should have a "Restore Default" button 
for the homepage.

Comment 1

[Samir Gehani]

Nominate with justification if you feel strongly about this for Mach V.  At this
point, netscape developers should not be working bugs that are non-nsbeta1+.

-> Future bin for now

Comment 2

[Stephen Walker]

Attachment: patch

Comment 3

[Stephen Walker]

Attachment: Screenshot

Comment 4

[Samir Gehani]

Comment on attachment 82893 [details] [diff] [review]
patch

r=sgehani

Comment 5

[Alec Flett]

Comment on attachment 82893 [details] [diff] [review]
patch

hmm.. does this really retrieve the default page? I mean, if the user has
overridden it, won't nsIPrefLocalizedString retrieve the overridden verison?

Comment 6

[Stephen Walker]

Yes because getDefaultBranch always calls the default pref value, not the 
overridden one. 

"When using a Get method a default value will always be returned" 
http://lxr.mozilla.org/mozilla/source/modules/libpref/public/nsIPrefService.idl#
134.

Comment 7

[Alec Flett]

Comment on attachment 82893 [details] [diff] [review]
patch

oh.. duh :) I forgot about getDefaultBranch!
sr=alecf

Comment 8

[Stephen Walker]

-> me

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

C:\moz_src\mozilla\xpfe\components\prefwindow\resources\content>cvs commit -m
"Bug 127337.  Restore Default for Home Page button in Navigator.  Patch by
Stephen Walker <[e-mail]> r=samir, sr=alecf." pre
f-navigator.js
Checking in pref-navigator.js;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-navigator.js,v
 <--  pref-navigator.js
new revision: 1.8; previous revision: 1.7
done

C:\moz_src\mozilla\xpfe\components\prefwindow\resources\content>cvs commit -m
"Bug 127337.  Restore Default for Home Page button in Navigator.  Patch by
Stephen Walker <[e-mail]> r=samir, sr=alecf." pre
f-navigator.xul
Checking in pref-navigator.xul;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-navigator.xul,v
 <--  pref-navigator.xul
new revision: 1.63; previous revision: 1.62
done

C:\moz_src\mozilla\xpfe\components\prefwindow\resources\locale\en-US>cvs commit
-m "Bug 127337.  Restore Default for Home Page button in Navigator.  Patch by
Stephen Walker <[e-mail]> r=samir, s
" pref-navigator.dtd
Checking in pref-navigator.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-navigator.dtd,v
 <--  pref-navigator.dtd
new revision: 1.21; previous revision: 1.20
done

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.09.16.08 comm trunk builds.