Restore Default for Home Page button

VERIFIED FIXED in mozilla1.0

Status

P3
normal
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: rebron, Assigned: stdowa+bugzilla)

Tracking

Trunk
mozilla1.0
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
Navigator--> Homepage Pref should have a "Restore Default" button 
for the homepage.

Comment 1

17 years ago
Nominate with justification if you feel strongly about this for Mach V.  At this
point, netscape developers should not be working bugs that are non-nsbeta1+.

-> Future bin for now
Target Milestone: --- → Future
(Assignee)

Comment 2

17 years ago
Created attachment 82893 [details] [diff] [review]
patch
(Assignee)

Comment 3

17 years ago
Created attachment 83411 [details]
Screenshot

Comment 4

17 years ago
Comment on attachment 82893 [details] [diff] [review]
patch

r=sgehani
Attachment #82893 - Flags: review+

Comment 5

17 years ago
Comment on attachment 82893 [details] [diff] [review]
patch

hmm.. does this really retrieve the default page? I mean, if the user has
overridden it, won't nsIPrefLocalizedString retrieve the overridden verison?
(Assignee)

Comment 6

17 years ago
Yes because getDefaultBranch always calls the default pref value, not the 
overridden one. 

"When using a Get method a default value will always be returned" 
http://lxr.mozilla.org/mozilla/source/modules/libpref/public/nsIPrefService.idl#
134.

Comment 7

17 years ago
Comment on attachment 82893 [details] [diff] [review]
patch

oh.. duh :) I forgot about getDefaultBranch!
sr=alecf
Attachment #82893 - Flags: superreview+
(Assignee)

Comment 8

17 years ago
-> me
Assignee: sgehani → walk84
C:\moz_src\mozilla\xpfe\components\prefwindow\resources\content>cvs commit -m
"Bug 127337.  Restore Default for Home Page button in Navigator.  Patch by
Stephen Walker <walk84@yahoo.com> r=samir, sr=alecf." pre
f-navigator.js
Checking in pref-navigator.js;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-navigator.js,v
 <--  pref-navigator.js
new revision: 1.8; previous revision: 1.7
done

C:\moz_src\mozilla\xpfe\components\prefwindow\resources\content>cvs commit -m
"Bug 127337.  Restore Default for Home Page button in Navigator.  Patch by
Stephen Walker <walk84@yahoo.com> r=samir, sr=alecf." pre
f-navigator.xul
Checking in pref-navigator.xul;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-navigator.xul,v
 <--  pref-navigator.xul
new revision: 1.63; previous revision: 1.62
done

C:\moz_src\mozilla\xpfe\components\prefwindow\resources\locale\en-US>cvs commit
-m "Bug 127337.  Restore Default for Home Page button in Navigator.  Patch by
Stephen Walker <walk84@yahoo.com> r=samir, s
" pref-navigator.dtd
Checking in pref-navigator.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-navigator.dtd,v
 <--  pref-navigator.dtd
new revision: 1.21; previous revision: 1.20
done
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Priority: -- → P3
Target Milestone: Future → mozilla1.0
vrfy'd fixed with 2002.09.16.08 comm trunk builds.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.