1273390 - Remove use of FlushableTaskQueue::Flush() from WaveDataDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Similar to bug 1272232.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

review: https://reviewboard.mozilla.org/r/53106
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7757e1861d99

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1273390. Part 1 - move some functions to private. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53108/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1273390. Part 2 - add assertions. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53110/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1273390. Part 3 - rename some functions to be consistent with other sub-classes of MediaDataDecoder. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53112/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1273390. Part 4 - remove use of FlushableTaskQueue::Flush(). r=jya.

Review commit: https://reviewboard.mozilla.org/r/53114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53114/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1273390. Part 5 - remove use of FlushableTaskQueue. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53116/

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8753633 [details]
MozReview Request: Bug 1273390. Part 1 - move some functions to private. r=jya.

https://reviewboard.mozilla.org/r/53108/#review50190

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 8753634 [details]
MozReview Request: Bug 1273390. Part 2 - add assertions. r=jya.

https://reviewboard.mozilla.org/r/53110/#review50192

::: dom/media/platforms/agnostic/WAVDecoder.cpp:95
(Diff revision 1)
>  }
>  
>  bool
>  WaveDataDecoder::DoDecode(MediaRawData* aSample)
>  {
> +  MOZ_ASSERT(mTaskQueue->IsCurrentThreadIn());

I'm guessing you're going to remove those later, or change it to make sur you're on the decoder's.

So do we even need those here?

I would argue that we don't even need a task queue for this decoder... it complicate things for no purpose being a very minimalistic decoder.

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8753635 [details]
MozReview Request: Bug 1273390. Part 3 - rename some functions to be consistent with other sub-classes of MediaDataDecoder. r=jya.

https://reviewboard.mozilla.org/r/53112/#review50194

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8753636 [details]
MozReview Request: Bug 1273390. Part 4 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/53114/#review50196

I still think that really, using a task queue here is unecessary to start with.

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8753637 [details]
MozReview Request: Bug 1273390. Part 5 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/53116/#review50198

Comment 12

[Jean-Yves Avenard [:jya]]

https://reviewboard.mozilla.org/r/53110/#review50192

wav is used as-is, never in combination of another container...

You could just open a new bug to remove the use of task queue.

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

OK. I will open a new bug to remove the task queue.

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07444c6cc10b
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fb307fb7ea5
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ccbc1e62126
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc7ad5fa9c00
https://hg.mozilla.org/integration/mozilla-inbound/rev/8874b3750f2b

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07444c6cc10b
https://hg.mozilla.org/mozilla-central/rev/8fb307fb7ea5
https://hg.mozilla.org/mozilla-central/rev/3ccbc1e62126
https://hg.mozilla.org/mozilla-central/rev/cc7ad5fa9c00
https://hg.mozilla.org/mozilla-central/rev/8874b3750f2b