Closed Bug 1273390 Opened 4 years ago Closed 4 years ago

Remove use of FlushableTaskQueue::Flush() from WaveDataDecoder

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

Similar to bug 1272232.
Assignee: nobody → jwwang
Blocks: 1270039
Review commit: https://reviewboard.mozilla.org/r/53108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53108/
Attachment #8753633 - Flags: review?(jyavenard)
Attachment #8753634 - Flags: review?(jyavenard)
Attachment #8753635 - Flags: review?(jyavenard)
Attachment #8753636 - Flags: review?(jyavenard)
Attachment #8753637 - Flags: review?(jyavenard)
Comment on attachment 8753633 [details]
MozReview Request: Bug 1273390. Part 1 - move some functions to private. r=jya.

https://reviewboard.mozilla.org/r/53108/#review50190
Attachment #8753633 - Flags: review?(jyavenard) → review+
Comment on attachment 8753634 [details]
MozReview Request: Bug 1273390. Part 2 - add assertions. r=jya.

https://reviewboard.mozilla.org/r/53110/#review50192

::: dom/media/platforms/agnostic/WAVDecoder.cpp:95
(Diff revision 1)
>  }
>  
>  bool
>  WaveDataDecoder::DoDecode(MediaRawData* aSample)
>  {
> +  MOZ_ASSERT(mTaskQueue->IsCurrentThreadIn());

I'm guessing you're going to remove those later, or change it to make sur you're on the decoder's.

So do we even need those here?

I would argue that we don't even need a task queue for this decoder... it complicate things for no purpose being a very minimalistic decoder.
Attachment #8753634 - Flags: review?(jyavenard) → review+
Attachment #8753635 - Flags: review?(jyavenard) → review+
Comment on attachment 8753635 [details]
MozReview Request: Bug 1273390. Part 3 - rename some functions to be consistent with other sub-classes of MediaDataDecoder. r=jya.

https://reviewboard.mozilla.org/r/53112/#review50194
Comment on attachment 8753636 [details]
MozReview Request: Bug 1273390. Part 4 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/53114/#review50196

I still think that really, using a task queue here is unecessary to start with.
Attachment #8753636 - Flags: review?(jyavenard) → review+
Comment on attachment 8753637 [details]
MozReview Request: Bug 1273390. Part 5 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/53116/#review50198
Attachment #8753637 - Flags: review?(jyavenard) → review+
https://reviewboard.mozilla.org/r/53110/#review50192

wav is used as-is, never in combination of another container...

You could just open a new bug to remove the use of task queue.
OK. I will open a new bug to remove the task queue.
You need to log in before you can comment on or make changes to this bug.