1273394 - [TV][Home] In card selection page of add folder then pin any app to home will fail

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
1. Invoke Apps card
2. Press home key
3. Invoke add folder
4. Press home key
5. Choose any app then invoke option menu
6. Choose Pin to home (will go to card selection page)
7. Press back key

[Expected result]
App should pin to home successfully

[Actual result]
1. App doesn't pin to home successfully
2. If pressing home key twice, the app will be shown in home screen

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/9a3ed0cb72e84628ca6c2c3e5b9fc4f419059268
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344

Comment 1

[Luke Chang [:lchang] (inactive)]

After discussing with Jack, we decided to hide the card picker once the homescreen is dismissed.

Hi Jack, NI you just for a reminder to update the spec. Thanks.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1273394_tv_hide_cardpicker_when_close_home > mozilla-b2g:v2.6

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8753322 [details] [review]
[gaia] luke-chang:1273394_tv_hide_cardpicker_when_close_home > mozilla-b2g:v2.6

Thanks in advance.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8753322 [details] [review]
[gaia] luke-chang:1273394_tv_hide_cardpicker_when_close_home > mozilla-b2g:v2.6

Looks good to me

Comment 5

[Luke Chang [:lchang] (inactive)]

Thanks.

landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/6d3715fdf150de9db1689e78046595f9baf9266a

--

Leave a NI for the remainder to update the spec.

Comment 6

[Mike Lien[:mlien]]

verified and fixed with the latest build
v2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b

Comment 7

[Luke Chang [:lchang] (inactive)]

Clear out-of-date flags.