1273482 - Opening a new tab and a new private tab quickly will not display the correct number of opened tabs for the given mode

Status: RESOLVED WORKSFORME

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build d3c9de01
Device: IPhone 6 S (9.2.1)

Steps to reproduce:
1. Open 10 new tabs
2. Quickly open a new In Private tab
3. Quickly open a new tab
4. Repeat steps 2 and 3

Actual results:
- The number of opened tabs in a normal browsing session will be displayed as the number of tabs opened in a in private browsing session and vice-versa.

Expected results: 
- The current browsing sessions should display the correct number of open tabs

Comment 1

[Tyler Lacroix [:tlacroix]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1827

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8754012 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1827

Don't think this patch actually changes anything. I think the issue might be rooted in how we respond to fast user interactions poorly which sounds like a deeper issue.

Comment 3

[Adrian Oniga]

Can be reproduce on buddybuild #1886 with the following:
STR:
1.Open Firefox
2.Go to Private Browsing and open a tab
3.Tap the counter icon
4.Swipe down to access Widget and tap "New Tab"
5.Tap tab counter
6.Swipe down to access Widget and tap "New Private Tab"
7.Repeat step 4

Actual:
2.Tab is displayed in PB
3.Tab list is displayed
4.New tab is opened 
5.Tab list is displayed and the counter displays the correct number of opened pages(2)
6.New tab is opened in PB
7.The counter tab will show the wrong number of opened tabs in normal session (2) and in Private Browsing (3)

Expected:
7.The counter tab will show the correct number of opened tabs in normal session (3) and in Private Browsing (2)

Comment 4

[Simon Basca [:SimonB]]

Re-tested with master 35383ea54. Issue is no longer reproducible. Will re-open if encountered again.