1273506 - Can add a Tile to the ToC

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Fernando Campo (:fcampo)]

When clicking the 'Add Content' button (represented by '+'), a popup is shown with an input and a button to add a new Site to the room.

Clicking the button from the popup triggers the MetaData collection, closes the popup and a new Tile with the Site information is added to the ToC.

Comment 1

[Ian Bicking (:ianbicking)]

Note: first version should just use PageMetadata.jsm, and not worry about Bug 1273497

Comment 2

[Mark Banner (:standard8)]

(In reply to Ian Bicking (:ianb) from comment #1)
> Note: first version should just use PageMetadata.jsm, and not worry about
> Bug 1273497

For this bug, this isn't possible - the "+" sign doesn't necessarily mean we have the page loaded. Therefore we do need something like bug 1273497 or an alternate method (like loading in background/hidden).

So I think we need to de-prioritise this bug until we've got that resolved.

Note: we do already have the "+" functionality to add just the url. It isn't hooked up to persistence yet, but we should do that hook in a different bug.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

The UI should persist the URLs using the updateRoomContext action, and I think the handler in roomStore.js for updateRoomContext needs a bit of tweaking too.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Ok, please disregard comment 3.  The new theory is to (probably) use the ParticipantStore (or else another store based on the data made available in bug 1274171.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Sigh.  I actually meant the ToC being done in bug 1274179.

Comment 6

[Donovan Preston [:fzzzy]]

I'm not going to have time to work on this before london. Unassigning so someone else can take it.

To do this the right way probably involves setting up message passing between the toc page and the sidebar, so we don't have more than one firebase connection open. However, just opening a firebase connection in the toc page is good enough for a quick hack as long as another bug gets opened.

Comment 7

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1273506 > mozilla:akita

Comment 8

[Ed Lee :Mardak]

Comment on attachment 8761663 [details] [review]
[loop] mancas:bug1273506 > mozilla:akita

r=Mardak with various review comments fixed and added tests

Comment 9

[Ed Lee :Mardak]

https://github.com/mozilla/loop/commit/12a4399f88fe536b1a6354698768f8cab2e1ffb4