Closed
Bug 1273512
Opened 9 years ago
Closed 9 years ago
Show room's other participants presence when connected
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fcampo, Assigned: mancas)
References
Details
(Whiteboard: [akita-alpha])
Attachments
(1 file)
As a user, I can see a representation of the room's other participants:
- https://mozilla.aha.io/attachments/6274825287365941975
- List of participants is shown next to 'Add Content' button, on it's left.
- User's own presence is not shown on user's side.
- Only online users are shown (presence tracked on Firebase)
- Participants are represented with the first letter of the username on a circle
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 1•9 years ago
|
||
Assuming the presence is already tracked in Firebase, and showing it is only a matter of grabbing the username and transform it into a Letter Avatar
Points: --- → 2
Updated•9 years ago
|
Rank: 18
Priority: -- → P1
Whiteboard: [akita]
Updated•9 years ago
|
Whiteboard: [akita] → [akita-alpha]
Updated•9 years ago
|
Blocks: akita-dogfood
Updated•9 years ago
|
Rank: 18 → 13
Assignee | ||
Updated•9 years ago
|
Depends on: akita-participants-store
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8758132 -
Flags: review?(edilee)
Attachment #8758132 -
Flags: review?(dmose)
Attachment #8758132 -
Flags: review?(dcritchley)
Comment 3•9 years ago
|
||
Comment on attachment 8758132 [details] [review]
[loop] mancas:bug1273512 > mozilla:akita
r=Mardak sorry for my accidental change of the API
Attachment #8758132 -
Flags: review?(edilee)
Attachment #8758132 -
Flags: review?(dmose)
Attachment #8758132 -
Flags: review?(dcritchley)
Attachment #8758132 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
Ed, as you can see in the tech list:
- User's own presence is not shown on user's side.
So...how can we filter the owner? Is the userId stored in the room object?
Flags: needinfo?(edilee)
Comment 5•9 years ago
|
||
Manu is correct. When being alone in a room, you don't need to see you are there because you already know it. You want to know when another participant joins, maybe just to be informed, maybe to interact with them...there may be many reasons.
But in the end, the conclusion is that for the local user there's no avatar displayed and when guest joins, the avatar is displayed.
Comment 6•9 years ago
|
||
(In reply to Manuel Casas Barrado [:mancas] from comment #4)
> So...how can we filter the owner?
I think we can just assume `ParticipantStore` doesnt include the current user as part of its accessor method. This would be done via bug 1274172 when it adds the current participant. And if that bug doesn't, we can fix it in a followup.
Flags: needinfo?(edilee)
Comment 7•9 years ago
|
||
https://github.com/mozilla/loop/commit/9589a0678eff6c47251152a4ad05bed2a3a66cbc
dmose pushed an extra commit to fix a `porps` typo:
https://github.com/mozilla/loop/commit/926459fe8cbcc712ce2c763986ac661b38efd2b9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•