Closed
Bug 1273520
Opened 8 years ago
Closed 8 years ago
Missing renaming of NS_NewRunnable* and task.h includes
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(2 files, 4 obsolete files)
|
16.25 KB,
patch
|
Details | Diff | Splinter Review | |
|
58 bytes,
text/x-review-board-request
|
fabrice
:
review+
|
Details |
current m-c, device build
|
Assignee | |
Comment 1•8 years ago
|
||
likely a consequence of bug 1272415 ?
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8753722 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8753725 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8753794 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•8 years ago
|
||
on top of gecko git 1dd8a84da8056100adadeb4e1fafb4d906d16c0a, finally building completely
Attachment #8753816 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Summary: ../../../gecko/ipc/netd/Netd.cpp:220:60: error: 'NewRunnableFunction' was not declared in this scope → Missing renaming of NS_NewRunnable* and task.h includes
|
|
Assignee | |
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53574/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53574/
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8753928 [details] MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?fabrice Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53574/diff/1-2/
Attachment #8753928 -
Attachment description: MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r? → MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?khuey
Attachment #8753928 -
Flags: review?(khuey)
Comment on attachment 8753928 [details] MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?fabrice Please find a b2g peer to look at this.
Attachment #8753928 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 10•8 years ago
|
||
Comment on attachment 8753928 [details] MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?fabrice Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53574/diff/2-3/
Attachment #8753928 -
Attachment description: MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?khuey → MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?fabrice
Attachment #8753928 -
Flags: review?(fabrice)
|
||
Comment 11•8 years ago
|
||
Comment on attachment 8753928 [details] MozReview Request: Bug 1273520 - NS_NewRunnable* renaming and include task.h r?fabrice https://reviewboard.mozilla.org/r/53574/#review50342
Attachment #8753928 -
Flags: review?(fabrice) → review+
|
||
Comment 13•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b87c95b57992
You need to log in
before you can comment on or make changes to this bug.
Description
•