127358 - fast-update fails forever if error occurs in security

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

If an error occurs in a fast-update of security, the file
.fast_update-failed.tmp is created in the directory _above_ mozilla.  Since this
isn't deleted, from then on fast-update will fail when doing security.

Solution: delete the file in both directories, or when doing security use
"mozilla/.fast_update-failed.tmp" as the error file (so there's only one file).

Patch to be attached for the second variation (one file in the mozilla directory).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: client.mk patch

Trivial patch to correct this.	Didn't look at Windows makefiles; it's possible
they have a similar problem.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Very trivial patch, very safe.  Tested.  I'd suggest 0.9.9, but there's no need
to have the patch, it's merely a would-be-nice (I'd been unable to use
fast-update for months on one system and finally decided to find out why).

Comment 3

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

seawood - I can check this is if you like.  (We seem to have an a= without r/sr,
though)

Comment 5

[hacker formerly known as [e-mail]]

Comment on attachment 71010 [details] [diff] [review]
client.mk patch

r=cls

Comment 6

[hacker formerly known as [e-mail]]

Patch checked in.