1273603 - Re-enable rust sse2 code generation on win32

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

We can now revert bug 1252041.

Comment 1

[Ralph Giles (:rillian)]

Attachment: MozReview Request: Bug 1273603 - rust: enable sse2 code generation on win32. r?mshal

Now that we're no longer supporting x86 cpus without SSE2
instructions, we can relax this restriction.

Review commit: https://reviewboard.mozilla.org/r/53290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53290/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8753461 [details]
MozReview Request: Bug 1273603 - rust: enable sse2 code generation on win32. r?mshal

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53290/diff/1-2/

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8753461 [details]
MozReview Request: Bug 1273603 - rust: enable sse2 code generation on win32. r?mshal

Do we still need these lines in old-configure.in?

RUSTFLAGS="${RUSTFLAGS=}"
AC_SUBST(RUSTFLAGS)
export RUSTFLAGS

I don't see anything else that sets RUSTFLAGS.

Comment 4

[Ralph Giles (:rillian)]

I suppose not. I'd like to leave them in for now since they're useful for setting things on the command line, and really the --target option from rust.m4 should move there.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e163192093d

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c21202a775c

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5aab104f459

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5aab104f459