Closed Bug 1273603 Opened 4 years ago Closed 4 years ago

Re-enable rust sse2 code generation on win32

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

We can now revert bug 1252041.
Now that we're no longer supporting x86 cpus without SSE2
instructions, we can relax this restriction.

Review commit: https://reviewboard.mozilla.org/r/53290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53290/
Attachment #8753461 - Flags: review?(mshal)
Comment on attachment 8753461 [details]
MozReview Request: Bug 1273603 - rust: enable sse2 code generation on win32. r?mshal

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53290/diff/1-2/
Comment on attachment 8753461 [details]
MozReview Request: Bug 1273603 - rust: enable sse2 code generation on win32. r?mshal

Do we still need these lines in old-configure.in?

RUSTFLAGS="${RUSTFLAGS=}"
AC_SUBST(RUSTFLAGS)
export RUSTFLAGS

I don't see anything else that sets RUSTFLAGS.
Attachment #8753461 - Flags: review?(mshal) → review+
I suppose not. I'd like to leave them in for now since they're useful for setting things on the command line, and really the --target option from rust.m4 should move there.
https://hg.mozilla.org/mozilla-central/rev/a5aab104f459
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
No longer blocks: 1271755
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.