1273606 - Heroku Python build contains errors of form `pip-diff: error: no such option: --hash`

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

This is due to the Heroku Python buildpack using an older version of pip with pip-grep (which is run as part of the build to identify whether to install things like libmemcached).

I've filed an issue against the buildpack:
https://github.com/heroku/heroku-buildpack-python/issues/302

But the fix is to make pip-grep compatible with pip 8.x, which requires changes upstream, for which I've filed:
https://github.com/kennethreitz/pip-pop/issues/10

And then opened a PR for the fix:
https://github.com/kennethreitz/pip-pop/pull/12

And another PR for adding Travis testing so they avoid this kind of thing in the future:
https://github.com/kennethreitz/pip-pop/pull/11

Comment 1

[Ed Morley [:emorley]]

Still waiting for Kenneth to merge those two upstream PRs.

In the meantime I've opened a downstream PR that imports the pip 8 fixes (to speed things up when they are merged):
https://github.com/heroku/heroku-buildpack-python/pull/308

Comment 2

[Ed Morley [:emorley]]

In the meantime I've switched all three Heroku apps to using my fork of the buildpack, using eg:

heroku buildpacks:set -i 2 https://github.com/edmorley/heroku-buildpack-python.git#fix-pip8-support -a treeherder-heroku

Comment 3

[Ed Morley [:emorley]]

This is taking way too long - I now have some comments on the PRs but they still aren't merged.

As such, I've just opened a support ticket to escalate:
https://help.heroku.com/tickets/369532

Comment 4

[Ed Morley [:emorley]]

The Heroku ticket was closed with response from Kenneth:

"""
Thanks for the bug report. We are aware of the issue, and are working towards a solution. Those GitHub issues are a great place to track this. 
"""

I then responded with:

"""
I agree they should be the first port of call, which is why I opened the various tickets and also tried to provide a PR.
 
However the PR wasn't accepted due to an undocumented other issue, which I asked for further details about, but haven't had a reply. It's now been 2 months since https://github.com/kennethreitz/pip-pop/issues/8 was filed and we don't seem any closer to a resolution.

The reason why I opened this ticket was that I can imagine it's difficult to gauge importance of an issue (and thus how to prioritise employee time on it) when it's not tracked in the support tracker. It also seemed silly for Mozilla to pay $1000/month in premium support and yet to still be hesitant about raising tickets to raise awareness of issues that are affecting us :-)
"""

And left a comment on the PR:
https://github.com/heroku/heroku-buildpack-python/pull/308#issuecomment-231310733

Anyway, I'm going to mark this as fixed for now - since my fork of the buildpack means this doesn't block the Heroku migration - and I've filed bug 1285984 for chasing up official support later.