Closed Bug 1273625 Opened 5 years ago Closed 5 years ago

update tooltool win32 rust to target i686

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files)

Now that we're requiring SSE2, drop the i585-pc-windows-msvc target when building rust code.
We no longer need to support systems without SSE2, so we
can move to the standard i686 target.

Review commit: https://reviewboard.mozilla.org/r/53318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53318/
Attachment #8753488 - Flags: review?(mshal)
Attachment #8753489 - Flags: review?(mshal)
We were using 1.9 beta for i586 support. Now that it's no longer
necessary we can revert to the stable release.

This is a repack of the 1.8.0 upstream stable build targetting
only i686-pc-windows-msvc.

Review commit: https://reviewboard.mozilla.org/r/53316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53316/
Attachment #8753488 - Flags: review?(mshal) → review+
Comment on attachment 8753488 [details]
MozReview Request: Bug 1273625 - rust: target i686-pc-windows-msvc. r?mshal

https://reviewboard.mozilla.org/r/53318/#review50276
Attachment #8753489 - Flags: review?(mshal) → review+
Comment on attachment 8753489 [details]
MozReview Request: Bug 1273625 - rust: Update win32 builders to 1.8.0 stable. r?mshal

https://reviewboard.mozilla.org/r/53316/#review50278
It looks like this needs a clobber bump. We got build failures with rustc being invoked with both --target i586-pc-windows-msvc and --target i686-pc-windows-msvc, I think through autoconf caching. Clobber and retrigger succeeded, some builds after the backout failed the same way.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.