Closed Bug 1273633 Opened 4 years ago Closed 4 years ago

Create in-tree per-branch configuration

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

References

Details

Attachments

(2 files)

Ideally, every decision task has the same format, just parameterized based on the push.  That will need to be expanded out to some branch-specific options (e.g., use try syntax on try).
Attachment #8753544 - Flags: review?(garndt) → review+
Comment on attachment 8753544 [details]
MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt

https://reviewboard.mozilla.org/r/53342/#review50266

::: .taskcluster.yml:16
(Diff revision 1)
>    # side to whatever scopes are set by mozilla-taskcluster.
>    - queue:*
>    - docker-worker:*
>    - scheduler:*
>  
> +# Available moustache parameters (see the mozilla-taskcluster source):

Not that it really matters, but I believe the underlying package is called "mustache".
Comment on attachment 8753545 [details]
MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt

https://reviewboard.mozilla.org/r/53344/#review50268

::: taskcluster/taskgraph/decision.py:104
(Diff revision 1)
> +
> +    project = parameters['project']
> +    try:
> +        parameters.update(PER_PROJECT_PARAMETERS[project])
> +    except KeyError:
> +        print("WARNING: using default project parameters; add {} to "

nit: The warning just seems like it might be a little incomplete with why a user might want to add the project to the per_project_parameters.
Attachment #8753545 - Flags: review?(garndt) → review+
Comment on attachment 8753544 [details]
MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53342/diff/1-2/
Comment on attachment 8753545 [details]
MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53344/diff/1-2/
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.