1273633 - Create in-tree per-branch configuration

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Ideally, every decision task has the same format, just parameterized based on the push.  That will need to be expanded out to some branch-specific options (e.g., use try syntax on try).

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt

Review commit: https://reviewboard.mozilla.org/r/53342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53342/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt

Review commit: https://reviewboard.mozilla.org/r/53344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53344/

Comment 3

[Greg Arndt [:garndt]]

Comment on attachment 8753544 [details]
MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt

https://reviewboard.mozilla.org/r/53342/#review50266

::: .taskcluster.yml:16
(Diff revision 1)
>    # side to whatever scopes are set by mozilla-taskcluster.
>    - queue:*
>    - docker-worker:*
>    - scheduler:*
>  
> +# Available moustache parameters (see the mozilla-taskcluster source):

Not that it really matters, but I believe the underlying package is called "mustache".

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8753545 [details]
MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt

https://reviewboard.mozilla.org/r/53344/#review50268

::: taskcluster/taskgraph/decision.py:104
(Diff revision 1)
> +
> +    project = parameters['project']
> +    try:
> +        parameters.update(PER_PROJECT_PARAMETERS[project])
> +    except KeyError:
> +        print("WARNING: using default project parameters; add {} to "

nit: The warning just seems like it might be a little incomplete with why a user might want to add the project to the per_project_parameters.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8753544 [details]
MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53342/diff/1-2/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8753545 [details]
MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53344/diff/1-2/

Comment 7

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/53344/#review50314

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee5bdc58edab
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fb747099412

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee5bdc58edab
https://hg.mozilla.org/mozilla-central/rev/3fb747099412