Closed
Bug 1273633
Opened 8 years ago
Closed 8 years ago
Create in-tree per-branch configuration
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(2 files)
Ideally, every decision task has the same format, just parameterized based on the push. That will need to be expanded out to some branch-specific options (e.g., use try syntax on try).
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53342/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53342/
Attachment #8753544 -
Flags: review?(garndt)
Attachment #8753545 -
Flags: review?(garndt)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53344/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53344/
Updated•8 years ago
|
Attachment #8753544 -
Flags: review?(garndt) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8753544 [details] MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt https://reviewboard.mozilla.org/r/53342/#review50266 ::: .taskcluster.yml:16 (Diff revision 1) > # side to whatever scopes are set by mozilla-taskcluster. > - queue:* > - docker-worker:* > - scheduler:* > > +# Available moustache parameters (see the mozilla-taskcluster source): Not that it really matters, but I believe the underlying package is called "mustache".
Comment 4•8 years ago
|
||
Comment on attachment 8753545 [details] MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt https://reviewboard.mozilla.org/r/53344/#review50268 ::: taskcluster/taskgraph/decision.py:104 (Diff revision 1) > + > + project = parameters['project'] > + try: > + parameters.update(PER_PROJECT_PARAMETERS[project]) > + except KeyError: > + print("WARNING: using default project parameters; add {} to " nit: The warning just seems like it might be a little incomplete with why a user might want to add the project to the per_project_parameters.
Attachment #8753545 -
Flags: review?(garndt) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8753544 [details] MozReview Request: Bug 1273633: a non-branch-specific taskgraph definition; r?garndt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53342/diff/1-2/
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8753545 [details] MozReview Request: Bug 1273633: support per-branch config in the decision task; r?garndt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53344/diff/1-2/
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee5bdc58edab https://hg.mozilla.org/integration/mozilla-inbound/rev/3fb747099412
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ee5bdc58edab https://hg.mozilla.org/mozilla-central/rev/3fb747099412
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•