1273663 - Open ToC in a new window

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

As a Firefox room creator, I see a new dedicated Hello window open with a Table of Contents tab that I can use to keep track of some web pages.

Acceptance Criteria:

* Table of Contents tab opens in new window.

Notes:

* Pass about:looptoc to chrome request that uses XUL openWindow?  Different windowtype?
* Make sure all errors are handled so sidebar always opened here and in other bugs

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] dmose:toc-dedicated-window-1273663 > mozilla:akita

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

This probably wants a bit of cleanup and maybe some tests (which I'll do tomorrow). That said, even in it's current form, this should unblock folks who want to base other things on the ToC stuff..

I also don't think it'll be very hard to get the sidebar correctly opening as well (crossing my fingers as I type this).

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

The mochitests/xpcshell tests are broken on akita now, and I don't want to block further akita progress to clean them up this second, so I've just cleaned up the code.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8754614 [details] [review]
[loop] dmose:toc-dedicated-window-1273663 > mozilla:akita

I'm curious in particular to any thoughts you might have about the XXX comments in the bug...

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8754614 [details] [review]
[loop] dmose:toc-dedicated-window-1273663 > mozilla:akita

I've commented on the PR.

I think this is something that could be landed to help unblock other work, but I'm not quite clear on if you want to get any of the tests working or not. It might be worth considering if this needs the "flag on window" to fully unblock just some or all the other work.

Can you also make sure we have a bug on file for ensuring only one instance of the room can be opened? (i.e. switch to existing window if necessary).

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Mark Banner (:standard8) from comment #5)
> Comment on attachment 8754614 [details] [review]
> [loop] dmose:toc-dedicated-window-1273663 > mozilla:akita
> 
> I've commented on the PR.
> 
> I think this is something that could be landed to help unblock other work,
> but I'm not quite clear on if you want to get any of the tests working or
> not. 

I've filed bug 1275099 to get the tests in a state that doesn't discourage running them or writing new ones.

I think we want to land the minimal thing in this bug to get even a few other bugs folks unblocked ASAP.

> It might be worth considering if this needs the "flag on window" to
> fully unblock just some or all the other work.

I'm inclined to try and do this incrementally instead, and have that happen as part of the first bug that needs that capability, since the later we do this, the better we understand our requirements and are thus likely to structure it more appropriately.

> Can you also make sure we have a bug on file for ensuring only one instance
> of the room can be opened? (i.e. switch to existing window if necessary).

Bug 1275107 is now on file.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

I've also filed bug 1275115 about deciding what we want to do in private browsing mode.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8754614 [details] [review]
[loop] dmose:toc-dedicated-window-1273663 > mozilla:akita

r=Standard8 with the extra comment.