Closed Bug 1273671 Opened 8 years ago Closed 8 years ago

Land version 1.4.0 of the Loop system add-on in mozilla-central

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox48+ fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 + fixed
firefox49 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

(Whiteboard: [btpp-fix-now])

Attachments

(2 files)

Attachment #8753551 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/878623e95803
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8753551 [details] [diff] [review]
Land version 1.4.0 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Users using FxA to sign in won't be able to create rooms and might not be able to manage existing rooms properly. Also includes latest improvements to Hello, see below.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, has tests.
[Risks and why]: The patch is big because we've changed how we process files. We've also upgraded our react version as well. Most of the other changes in this release are small/well focussed that have low risk to the add-on and other parts of FF.
[String/UUID change made/needed]: None

Changes in this release:

- Fixes for users signed into Hello with FxA
- Notifications in the text chat when a user joins the room
- Disable the conversation window pop-out option permanently, as we've not been able to fix the e10s issues (we're working on a future change that moves away from the conversation window).
- Some small backend changes: Update React, improve some of our stores, use Babel to preprocess our files so we can use es6 consistently throughout the Hello code base, but still work with other browsers (mainly standalone related).
Attachment #8753551 - Flags: approval-mozilla-aurora?
Comment on attachment 8753551 [details] [diff] [review]
Land version 1.4.0 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

new hello version, taking it
Attachment #8753551 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1282823
Approval Request Comment
[Feature/regressing bug #]: Firefox Hello.

This is part of the Firefox Hello 1.4.2 system add-on update that shipped to 47.0.1 users (along with bug 1281619 and bug 1282899).

It should be landed in release should there be another dot release, so that users get the correct version of the add-on.
Attachment #8771388 - Flags: approval-mozilla-release?
Comment on attachment 8771388 [details] [diff] [review]
mozilla-release version

Don't think we will do a dot release of 47
Attachment #8771388 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.