1273732 - [TV][Home] Press back key in card picker will retern to home directly if rename folder but no any card selected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

[Description]
According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ) page 12, if selecting any card or rename, leaving page should show confirmation dialog

[Testing Steps]
1. Invoke add folder
2. Rename folder
3. Press back key

[Expected result]
Should show confirmation dialog

[Actual result]
Return to home directly

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/c5cceac45c13eab6a297074d55261610d8a0880f
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1273732-no-prompt-after-name-changed-in-Card-Picker-add-mode > mozilla-b2g:v2.6

Comment 2

[Fischer [:Fischer]]

Comment on attachment 8754237 [details] [review]
[gaia] Fischer-L:bug_1273732-no-prompt-after-name-changed-in-Card-Picker-add-mode > mozilla-b2g:v2.6

@Luke,
This patch tracks if name input has been changed and prompt accordingly when user presses Back key during adding folder.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8754237 [details] [review]
[gaia] Fischer-L:bug_1273732-no-prompt-after-name-changed-in-Card-Picker-add-mode > mozilla-b2g:v2.6

Looks good!

Comment 4

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/44ae8453e642fc3cd1bb57177beb60615bf64f9c

Comment 5

[Mike Lien[:mlien]]

verified and fixed with the latest build
v2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b