Closed
Bug 1273732
Opened 8 years ago
Closed 8 years ago
[TV][Home] Press back key in card picker will retern to home directly if rename folder but no any card selected
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)
Tracking
(blocking-b2g:2.6+)
VERIFIED
FIXED
| blocking-b2g | 2.6+ |
People
(Reporter: mlien, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
|
[gaia] Fischer-L:bug_1273732-no-prompt-after-name-changed-in-Card-Picker-add-mode > mozilla-b2g:v2.6
46 bytes,
text/x-github-pull-request
|
lchang
:
review+
|
Details | Review |
[Description] According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ) page 12, if selecting any card or rename, leaving page should show confirmation dialog [Testing Steps] 1. Invoke add folder 2. Rename folder 3. Press back key [Expected result] Should show confirmation dialog [Actual result] Return to home directly [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/c5cceac45c13eab6a297074d55261610d8a0880f gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → fliu
|
||
Updated•8 years ago
|
blocking-b2g: 2.6? → 2.6+
|
||
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8754237 [details] [review] [gaia] Fischer-L:bug_1273732-no-prompt-after-name-changed-in-Card-Picker-add-mode > mozilla-b2g:v2.6 @Luke, This patch tracks if name input has been changed and prompt accordingly when user presses Back key during adding folder.
Attachment #8754237 -
Flags: review?(lchang)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8754237 [details] [review] [gaia] Fischer-L:bug_1273732-no-prompt-after-name-changed-in-Card-Picker-add-mode > mozilla-b2g:v2.6 Looks good!
Attachment #8754237 -
Flags: review?(lchang) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/44ae8453e642fc3cd1bb57177beb60615bf64f9c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 5•8 years ago
|
||
verified and fixed with the latest build v2.6 simulator gaia: https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895 gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•