Closed
Bug 1273749
Opened 8 years ago
Closed 8 years ago
Address misc issues with nsNSSCertValidity
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
nsNSSCertValidity has the following issues: - Does not check for NSS shut down. - Provides an irrelevant zero argument constructor. - Does not explicitly delete the unwanted copy constructor and assignment operators. - Misc style issues. - Doesn't have a dedicated test. These should be addressed.
|
Assignee | |
Comment 1•8 years ago
|
||
Prior to the changes here, nsNSSCertValidity had the following issues: - Did not check for NSS shut down. - Provided an irrelevant zero argument constructor. - Did not explicitly delete the unwanted copy constructor and assignment operators. - Misc style issues. - Did not have a dedicated test. Review commit: https://reviewboard.mozilla.org/r/53832/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53832/
Attachment #8754203 -
Flags: review?(dkeeler)
Comment on attachment 8754203 [details] MozReview Request: Bug 1273749 - Address misc issues with nsNSSCertValidity. r=keeler https://reviewboard.mozilla.org/r/53832/#review50738 Great!
Attachment #8754203 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8754203 [details] MozReview Request: Bug 1273749 - Address misc issues with nsNSSCertValidity. r=keeler Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53832/diff/1-2/
Attachment #8754203 -
Attachment description: MozReview Request: Bug 1273749 - Address misc issues with nsNSSCertValidity. → MozReview Request: Bug 1273749 - Address misc issues with nsNSSCertValidity. r=keeler
|
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks for the review! https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5524062b26ee92187baf7c205b840933072bb0f (I don't know why the Android xpcshell jobs aren't showing up as finished - the raw logs at https://archive.mozilla.org/pub/mobile/try-builds/cykesiopka.bmo@gmail.com-e5524062b26ee92187baf7c205b840933072bb0f/try-android-api-15-debug/ suggest that the jobs have already finished and all the tests I wanted to run have been run.)
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad0bd769db04
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•