1273773 - [TV][Home] Add Folder button should use icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[Fischer [:Fischer]]

Currently the Add Folder button is labeled by the "Add folder" text. Should change it to use icon instead of using text .

Comment 1

[Joseph Yeh [:joseph]]

Attachment: icon_add folder_n.png

Comment 2

[Joseph Yeh [:joseph]]

Attachment: icon_add folder_s.png

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6

Comment 4

[Joseph Yeh [:joseph]]

Comment on attachment 8754228 [details] [review]
[gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6

Hi Luke, 

This patch will remove settings button and replace add folder button with icon.

Please take a look, thanks!

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8754228 [details] [review]
[gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6

Let's try to use "filter: invert(100%);" to do the transition on the icon. Also, please remove the handler of the setting button as well. Thanks.

Comment 6

[Joseph Yeh [:joseph]]

Comment on attachment 8754228 [details] [review]
[gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6

Hi Luke,

I've updated the patch, please take a look.

Thanks!

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8754228 [details] [review]
[gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6

Nice work!

Comment 8

[Joseph Yeh [:joseph]]

Landed in gaia v2.6

https://github.com/mozilla-b2g/gaia/commit/8e72a88a1513f22b57baf5163ec37f40f30a75e7

Comment 9

[Mike Lien[:mlien]]

verified and fixed with the latest build
v2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b