Closed
Bug 1273778
Opened 9 years ago
Closed 9 years ago
adds separate class extension to match guidelines
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tiago.martinho, Assigned: tiago.martinho)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/602.1.31 (KHTML, like Gecko) Version/9.1.1 Safari/601.6.17
Steps to reproduce:
It is not a bug but rather a mismatch between the swift guidelines
Actual results:
The BackForwardListViewController implements the table view protocol where the class is defined rather than in an extension
Expected results:
adds separate class extension in BackForwardListViewController for the table view protocol methods in order to adhere to the swift style guide
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8753702 -
Flags: review?(aaron.train)
|
||
Updated•9 years ago
|
Attachment #8753702 -
Flags: review?(aaron.train) → review?(bnicholson)
|
|
||
Updated•9 years ago
|
Assignee: nobody → tiago.martinho
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Updated•9 years ago
|
Attachment #8753702 -
Flags: review?(bnicholson) → review+
|
|
||
Comment 2•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•