Closed
Bug 1273809
Opened 8 years ago
Closed 8 years ago
[TV][Home] When card picker's limitation banner shown then press down arrow key will cause whole screen scroll up
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(blocking-b2g:2.6?)
VERIFIED
FIXED
| blocking-b2g | 2.6? |
People
(Reporter: mlien, Assigned: lchang)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(2 files)
Screenshot from 2016-05-18 16:32:39.png
[Testing Steps] 0. More than 9 cards in home 1. Invoke add folder 2. Select more than 9 cards 3. While notification banner shown -> Press down arrow key [Expected result] Only can move down to another row or Done button [Actual result] Whole screen scrolls up [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/c5cceac45c13eab6a297074d55261610d8a0880f gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → lchang
Status: NEW → ASSIGNED
|
||
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8753776 [details] [review] [gaia] luke-chang:1273809_tv_whole_page_scroll_after_banner > mozilla-b2g:v2.6 Hi Rex, This bug is caused because the banner's DOM is only set "visibility: hidden" not "display: none". That is, the element will stay outside of the screen and enable the scrollbar. There are two choices to fix this problem: set its "display" to "none" or remove the entire element. I chose the latter because I think this element is not quite important to live in DOM tree forever. What do you think?
Attachment #8753776 -
Flags: review?(rexboy)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8753776 [details] [review] [gaia] luke-chang:1273809_tv_whole_page_scroll_after_banner > mozilla-b2g:v2.6 Removing looks goo to me. Thanks!
Attachment #8753776 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/5ceb26c23f29a37b6a73338864783fc0d29cc646
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 5•8 years ago
|
||
verified and fixed with the latest build v2.6 simulator gaia: https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895 gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•