Closed Bug 1273823 Opened 4 years ago Closed 4 years ago

Optimize CreateSourceSurfaceFromLockedMacIOSurface()

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Keywords: feature)

Attachments

(1 file, 4 obsolete files)

By Bug 1230641 AppleVDADecoder output became UYVY (YUV422). It is converted to SurfaceFormat::B8G8R8X8 in CreateSourceSurfaceFromLockedMacIOSurface().
It seems not efficient enough.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/MacIOSurfaceHelpers.cpp#86
Assignee: nobody → sotaro.ikeda.g
Attached patch wip patch (obsolete) — Splinter Review
attachment 8753733 [details] [diff] [review] improved a performance. But the improvement seems not good enough. The approach of Bug 1254874 comment 2 might help.
Keywords: feature
Attached patch wip patch (obsolete) — Splinter Review
Rebased.
Attachment #8753733 - Attachment is obsolete: true
Summary: Add UYVY support to gfx/ycbcr → Optimize CreateSourceSurfaceFromLockedMacIOSurface()
Attachment #8787083 - Flags: review?(jmuizelaar)
Comment on attachment 8787083 [details] [diff] [review]
patch - Optimize CreateSourceSurfaceFromLockedMacIOSurface()

Change review request to :nical, since jeff is in PTO.
Attachment #8787083 - Flags: review?(jmuizelaar) → review?(nical.bugzilla)
Attachment #8787083 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6acc0713f779
Optimize CreateSourceSurfaceFromLockedMacIOSurface() r=nical
https://hg.mozilla.org/mozilla-central/rev/6acc0713f779
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1313518
Depends on: 1313444
You need to log in before you can comment on or make changes to this bug.