Optimize CreateSourceSurfaceFromLockedMacIOSurface()

RESOLVED FIXED in Firefox 51

Status

()

Core
Graphics
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks: 1 bug, {feature})

unspecified
mozilla51
feature
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

2 years ago
By Bug 1230641 AppleVDADecoder output became UYVY (YUV422). It is converted to SurfaceFormat::B8G8R8X8 in CreateSourceSurfaceFromLockedMacIOSurface().
It seems not efficient enough.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/MacIOSurfaceHelpers.cpp#86
(Assignee)

Updated

2 years ago
Blocks: 1253062
(Assignee)

Updated

2 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

2 years ago
Created attachment 8753733 [details] [diff] [review]
wip patch
(Assignee)

Comment 2

2 years ago
attachment 8753733 [details] [diff] [review] improved a performance. But the improvement seems not good enough. The approach of Bug 1254874 comment 2 might help.
Keywords: feature
(Assignee)

Comment 3

a year ago
Created attachment 8781471 [details] [diff] [review]
wip patch

Rebased.
Attachment #8753733 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Summary: Add UYVY support to gfx/ycbcr → Optimize CreateSourceSurfaceFromLockedMacIOSurface()
(Assignee)

Comment 4

a year ago
Created attachment 8787081 [details] [diff] [review]
patch - Optimize CreateSourceSurfaceFromLockedMacIOSurface()
Attachment #8781471 - Attachment is obsolete: true
(Assignee)

Comment 5

a year ago
Created attachment 8787082 [details] [diff] [review]
patch - Optimize CreateSourceSurfaceFromLockedMacIOSurface()
Attachment #8787081 - Attachment is obsolete: true
(Assignee)

Comment 6

a year ago
Created attachment 8787083 [details] [diff] [review]
patch - Optimize CreateSourceSurfaceFromLockedMacIOSurface()
Attachment #8787082 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8787083 - Flags: review?(jmuizelaar)
(Assignee)

Comment 8

a year ago
Comment on attachment 8787083 [details] [diff] [review]
patch - Optimize CreateSourceSurfaceFromLockedMacIOSurface()

Change review request to :nical, since jeff is in PTO.
Attachment #8787083 - Flags: review?(jmuizelaar) → review?(nical.bugzilla)
Attachment #8787083 - Flags: review?(nical.bugzilla) → review+

Comment 9

a year ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6acc0713f779
Optimize CreateSourceSurfaceFromLockedMacIOSurface() r=nical

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6acc0713f779
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1313518
Depends on: 1313444
You need to log in before you can comment on or make changes to this bug.