1273833 - Fix failure of idbobjectstore_createIndex7-event_order.htm in web-platform test.

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

For createIndex6:
"rq_add1.success",
"rq_add2.success",
"rq_add3.error: AbortError",
"transaction.error: AbortError",
"db.error: AbortError",
"transaction.abort: AbortError",  <-- "ConstraintError" is expected
"db.abort: AbortError",           <-- "ConstraintError" is expected
"open_rq.error: ConstraintError"  <-- "AbortError" is expected

For createIndex7:
"rq_add1.success",
"rq_add2.error: ConstraintError",
"transaction.error: ConstraintError",
"db.error: ConstraintError",
"rq_add3.error: AbortError",
"transaction.error: AbortError",
"db.error: AbortError",
"transaction.abort: ConstraintError",
"db.abort: ConstraintError",
"open_rq.error: ConstraintError"  <-- "AbortError" is expected

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

There are 2 issues in this bug:
1. open_rq.error shall always be set to AbortError if version change transaction is aborted [1]:
"
3.3.1 Opening a database:
   8. If db's version is less than version, run these substeps:
      3. If the upgrade transaction was aborted, run the steps for closing a database connection with
         connection, create and return a new AbortError exception and abort these steps.
"

2. In createIndex6, the transaction.error was set to AbortError earlier by rq_add3.error in [2] instead of ConstraintError by [3], which doesn't comply to the requirement mentioned in [4]:
"
once the implementation determines that creating the index has failed, it MUST abort the transaction using the steps for aborting a transaction using an appropriate error as error. For example if creating the index failed due to quota reasons, QuotaExceededError MUST be used as error and if the index can't be created due to unique flag constraints, ConstraintError MUST be used as error.
"

For issue#1, it shall be fine to set the |openDatabaseOp->mResultCode| to NS_ERROR_DOM_INDEXEDDB_ABORT_ERR in VersionChangeTransaction::SendCompleteNotification().

However,
for issue#2, need to figure out whether the transaction.error shall be set by rq_add3 in this use case.

[1] http://w3c.github.io/IndexedDB/#opening
[2] https://hg.mozilla.org/mozilla-central/annotate/f3f2fa1d7eed5a8262f6401ef18ff8117a3ce43e/dom/indexedDB/IDBTransaction.cpp#l656
[3] https://hg.mozilla.org/mozilla-central/annotate/f3f2fa1d7eed5a8262f6401ef18ff8117a3ce43e/dom/indexedDB/IDBTransaction.cpp#l804
[4] http://w3c.github.io/IndexedDB/#dom-idbobjectstore-createindex

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

idbobjectstore_createIndex6-event_order.htm will be addressed in bug 1274161 instead due to different root cause.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2e8868dc8e7

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Always return AbortError of the Open DB Request if the Upgrade Transaction is Aborted.

|AbortError| is the only reason of IDBOpenRequest.onerror if the version change transaction is aborted according to |3.3.1 Opening a database| in [1].

To meet this requirement, the openDatabaseOp->mResultCode has to be set to AbortError in VersionChangeTransaction::SendCompleteNotification() if failed.

In addition, please be aware that, in test_temporary_storage.js, there are 2 possible error name in IDBOpenRequest.onerror:
1. AbortError: if VersionChangeTransaction is failed at DatabaseConnection::CommitWriteTransaction while commiting the result of VersionChangeTransaction.
2. QuotaExceededError: if IDBOpenRequest is failed at earlier stage at OpenDatabaseOp::DoDatabaseWork() while CreateStorageConnection() before running into State::BeginVersionChange.

[1] http://w3c.github.io/IndexedDB/#opening

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8754340 [details] [diff] [review]
(v1) Patch: Always return AbortError of the Open DB Request if the Upgrade Transaction is Aborted.

cancel the review because test_error_events_abort_transactions.html has to be modified accordingly as well.

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v2) Patch: Always return AbortError in IDBOpenRequest.onerror if the Upgrade Transaction is Aborted.

1. The detailed reason of this fix was explained at comment 4.
2. Fix the failure in error_events_abort_transactions_iframe.html accordingly.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8754340 [details] [diff] [review]
(v1) Patch: Always return AbortError of the Open DB Request if the Upgrade Transaction is Aborted.

Resume the review.
The reason of this change is explained in comment 4.

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8754340 [details] [diff] [review]
(v1) Patch: Always return AbortError of the Open DB Request if the Upgrade Transaction is Aborted.

sorry. resume the wrong one.

Comment 9

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2a556c64509

Comment 10

[Bevis Tseng[:bevis][:btseng](Exited)]

Treeherder result in comment 9 looks fine.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0f169cdd9d1
Always return AbortError of the Open DB Request if the Upgrade Transaction is aborted. r=khuey

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0f169cdd9d1