Closed Bug 1273864 Opened 8 years ago Closed 8 years ago

Menu pagination dots in Normal Browsing are the wrong color

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios-v5.0 --- verified
fxios 5.0+ ---

People

(Reporter: jhugman, Assigned: fluffyemily)

Details

Attachments

(1 file)

Pull request
48 bytes, text/x-github-pull-request
jhugman
: review+
tecgirl
: ui-review+
Details | Review 
From https://bugzilla.mozilla.org/show_bug.cgi?id=1265389#c8 :

> The pagination dots will need to shift to grey for normal browsing mode.
This occurs now because the menu now has enough items in to paginate.

STR: 
 
 * go to any open tab
 * hit menu
 * observe > 6 items.
 * look at the pager dots.
status-fxios-v5.0: --- → affected
tracking-fxios: --- → ?
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request — 

        Attachment #8756782 -
        Flags: ui-review?(randersen)

        Attachment #8756782 -
        Flags: review?(jhugman)

    
    

    
  
Comment on attachment 8756782 [details] [review]
Pull request

LGTM!

        Attachment #8756782 -
        Flags: review?(jhugman) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8756782 [details] [review]
Pull request

>https://github.com/mozilla/firefox-ios/pull/1855

        Attachment #8756782 -
        Flags: ui-review?(randersen) → ui-review+

    
    

    
  
Tested on master 80a24431.
The menu pagination dots have the correct color in Normal Browsing.
Status: RESOLVED → VERIFIED

          status-fxios-v5.0:
          affected → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: