Closed Bug 1273867 Opened 4 years ago Closed 4 years ago

Don't call checkIsDefinitelyOptimizedArguments for getprops other than .length or .callee

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We only need to watch out for .callee and .length getprops (in functions with lazy arguments).

This gets rid of an abort on a Knockout benchmark.
Attachment #8753814 - Flags: review?(hv1989)
Comment on attachment 8753814 [details] [diff] [review]
Patch

Review of attachment 8753814 [details] [diff] [review]:
-----------------------------------------------------------------

Good find!
Attachment #8753814 - Flags: review?(hv1989) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa0c71f97aff
Don't call checkIsDefinitelyOptimizedArguments for getprops other than .length or .callee. r=h4writer
https://hg.mozilla.org/mozilla-central/rev/fa0c71f97aff
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.