1273890 - [Elevated Update] Windows Silent update broken on Oak build containing OSX elevated code

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Operating Systems]:
The tests were performed on Windows 8.1 x32 and Windows 7 x32.

[Description]:
On Windows Oak build that contains merged code with OSX elevated changes the Windows Silent Update is broken (https://wiki.mozilla.org/Silent_Update_OS_Dialogs/TestPlan): more specifically, the UAC is requested during the update.

[Steps to Reproduce]:
1. Login to an Admin account. 
2. Set UAC on High.
3. Clean the OS: uninstall service, uninstall all Firefox'es.
4. Download and Install Oak build from: http://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-13-20-52-10-oak/firefox-49.0a1.en-US.win32.installer.exe\
5. Check for Updates and restart to update.

[Actual Result]:
The UAC is pop-ed up.

[Expected Result]:
The UAC is not pop-ed up during the update; update is performed silently.


[Notes:]
We checked update from Release 45 to Release 46 and update from Nightly49 to latest Nightly 49 and the update works as expected: silently -> UAC is not requested prior to update, hence our conclusion is that the problem is from the OSX elevated code.

Comment 1

[Stephen A Pohl [:spohl]]

Hi Adrian, could you try to reproduce this with a build from Oak prior to elevated updates landing? This build should do:
http://archive.mozilla.org/pub/firefox/nightly/2016/04/2016-04-05-04-04-09-oak/

Thanks!

Comment 2

[Adrian Florinescu [:aflorinescu]]

Hello Stephen, the above build doesn't contain the reported bug.

Comment 3

[Stephen A Pohl [:spohl]]

Please retest with the build that will become available here:
http://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-18-18-25-21-oak/

It would be great if you could also run another smoke test for elevated updates on OSX to make sure that we didn't break anything there.

Thanks!

Comment 4

[Stephen A Pohl [:spohl]]

(In reply to Stephen A Pohl [:spohl] from comment #3)
> Please retest with the build that will become available here:
> http://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-18-18-25-21-
> oak/
> 
> It would be great if you could also run another smoke test for elevated
> updates on OSX to make sure that we didn't break anything there.

Note: you will not be able to test 2 consecutive updates. Running through one elevated update should be sufficient.

Comment 5

[Stephen A Pohl [:spohl]]

Please set to "verified" once you've been able to confirm the fix. Thanks!