|CompositorBridgeParent::IsInCompositorThread| doesn't exist

RESOLVED FIXED in Firefox 49

Status

()

Core
Widget: Gonk
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This is a follow-up to bug 1273017.
I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]
Created attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/53516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53516/
Comment on attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53516/diff/1-2/
Attachment #8753858 - Attachment description: MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mwoodrow → MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow
Attachment #8753858 - Flags: review?(matt.woodrow)
(In reply to Alexandre LISSY :gerard-majax from comment #1)
> I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]

You don't. I have your patch applied and it doesn't fix the issue. And the linked attachment doesn't include the required changes.
Status: NEW → ASSIGNED
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #1)
> > I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]
> 
> You don't. I have your patch applied and it doesn't fix the issue. And the
> linked attachment doesn't include the required changes.

Oh, looking at your patch, I see it's about MOZ_ASSERT(). I did an opt build, that might explain why. Hence, I'm wondering if you are not missing a couple of bits from what I have in this very same file, about the same kind of changes.
Oh no, it's another issue, I misread, sorry :)
Comment on attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow

https://reviewboard.mozilla.org/r/53516/#review50446
Attachment #8753858 - Flags: review?(matt.woodrow) → review+

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5a9174f53a08
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.